New issue
Advanced search Search tips

Issue 700568 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Remove stale-while-revalidate and related code.

Project Member Reported by scottmg@chromium.org, Mar 10 2017

Issue description

This was an experiment that is being turned down for the time being.

https://bugs.chromium.org/p/chromium/issues/detail?id=561609#c10

Removing it will simplify some of the cases in separating c/b/loader from the rest of content/browser.
 
Blocking: 598073
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2625374404695b3c1c5e62c0b7921fdde1395c7c

commit 2625374404695b3c1c5e62c0b7921fdde1395c7c
Author: scottmg <scottmg@chromium.org>
Date: Wed Mar 22 01:42:48 2017

Remove stale-while-revalidate from content and chrome

This removes the code for the stale-while-revalidate experiment from
content and the flags entry from chrome. This simplifies some c/b/loader
separation particularly in resource_dispatcher_host_impl.cc.

See https://bugs.chromium.org/p/chromium/issues/detail?id=348877#c66 for
details on the experiment turndown.

BUG=348877, 700568 

Review-Url: https://codereview.chromium.org/2764683002
Cr-Commit-Position: refs/heads/master@{#458613}

[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/chrome/app/generated_resources.grd
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/chrome/browser/about_flags.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/BUILD.gn
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/DEPS
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/async_resource_handler_unittest.cc
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_driver.cc
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_driver.h
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_driver_unittest.cc
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_manager.cc
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_manager.h
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_manager_browsertest.cc
[delete] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/loader/async_revalidation_manager_unittest.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/netlog_observer_unittest.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/public/common/content_features.cc
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/public/common/content_features.h
[modify] https://crrev.com/2625374404695b3c1c5e62c0b7921fdde1395c7c/content/test/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69708855a86d235ff43a11c1b525f8518e608056

commit 69708855a86d235ff43a11c1b525f8518e608056
Author: scottmg <scottmg@chromium.org>
Date: Wed Mar 22 19:36:31 2017

Remove stale-while-revalidate from blink

The stale-while-revalidate experiment is being turned down for the
moment. This current implementation is removed due to complexity of
interaction with other existing efforts. See
https://bugs.chromium.org/p/chromium/issues/detail?id=561609#c10.

BUG=348877,  520613 ,  700568 

Review-Url: https://codereview.chromium.org/2767853003
Cr-Commit-Position: refs/heads/master@{#458842}

[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/LayoutTests/http/tests/cache/freshness-header.html
[delete] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/LayoutTests/http/tests/cache/resources/stale-while-revalidate.php
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/loader/fetch/Resource.h
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/network/HTTPParsers.cpp
[modify] https://crrev.com/69708855a86d235ff43a11c1b525f8518e608056/third_party/WebKit/Source/platform/network/HTTPParsers.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75221e53b71cc5eb37cbfb957124025259aa5dab

commit 75221e53b71cc5eb37cbfb957124025259aa5dab
Author: scottmg <scottmg@chromium.org>
Date: Mon Mar 27 19:50:22 2017

Remove stale-while-revalidate from net

The stale-while-revalidate experiment is being turned down for the
moment. This current implementation is removed due to complexity of
interaction with other existing efforts. See
https://bugs.chromium.org/p/chromium/issues/detail?id=561609#c10.

BUG=348877, 700568 

Review-Url: https://codereview.chromium.org/2763393002
Cr-Commit-Position: refs/heads/master@{#459857}

[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/base/load_flags_list.h
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_cache_transaction.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_cache_transaction.h
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_cache_unittest.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_headers.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_headers.h
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_headers_unittest.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_info.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_info.h
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/http/http_response_info_unittest.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/net/url_request/sdch_dictionary_fetcher.cc
[modify] https://crrev.com/75221e53b71cc5eb37cbfb957124025259aa5dab/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
I think I got most of this.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d731649d58a6ac8994005e86371079807c91651

commit 7d731649d58a6ac8994005e86371079807c91651
Author: scottmg <scottmg@chromium.org>
Date: Mon Mar 27 21:48:11 2017

Fix Cronet Android test after 755221e53

This test hardcodes a value from net/base/load_flags_list.h. :/

R=mmenke@chromium.org
BUG= 700568 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2777313002
Cr-Commit-Position: refs/heads/master@{#459892}

[modify] https://crrev.com/7d731649d58a6ac8994005e86371079807c91651/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Comment 7 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 8 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62fd25c52152db7dae62e5e21bd0fefa93032d74

commit 62fd25c52152db7dae62e5e21bd0fefa93032d74
Author: Adam Rice <ricea@chromium.org>
Date: Mon Aug 06 08:17:24 2018

Mark Net.AsyncRevalidation histograms as obsolete

I removed these histograms in March 2017 in
https://codereview.chromium.org/2764683002 but I forgot to mark them as
obsolete in histograms.xml.

Mark them as obsolete.

BUG= 700568 

Change-Id: I76e83d25ea45488ae8631c6402171dda3e61f987
Reviewed-on: https://chromium-review.googlesource.com/1161719
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580820}
[modify] https://crrev.com/62fd25c52152db7dae62e5e21bd0fefa93032d74/tools/metrics/histograms/histograms.xml

Sign in to add a comment