cros-disks: remove "force" option for unmount |
|||||
Issue descriptionThis is a follow-up on chromium:646224, which we deprecated the "force" option in the cros-disks's Unmmount DBus API. We should update chrome's cros_disks_client to stop using the "force" option, and then update cros-disks to fully remove the option.
,
Mar 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203 commit c5ff288ad5a1cb8a4d80d3babf302f6db70fe203 Author: Ben Chan <benchan@chromium.org> Date: Sat Mar 11 03:52:32 2017 Use lazy umount instead of force unmount in cros-disks tests. The "force" unmount option has been deprecated and ignored by cros-disks (CL:388592, chromium:646224). This CL updates the platform_CrosDisksArchive and platform_CrosDisksFilesystem test to use the "lazy" unmount option instead. BUG= chromium:700548 TEST=Run platform_CrosDisksArchive and platform_CrosDisksFilesystem. Change-Id: I79b104613c97d8f937e5e1a4dfde149ddad55a27 Reviewed-on: https://chromium-review.googlesource.com/452957 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203/client/site_tests/platform_CrosDisksFilesystem/platform_CrosDisksFilesystem.py [modify] https://crrev.com/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py
,
Mar 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/97bc80607220003de53fa8f34ff2fdf45adf1579 commit 97bc80607220003de53fa8f34ff2fdf45adf1579 Author: Ben Chan <benchan@chromium.org> Date: Sat Mar 18 03:12:20 2017 cros-disks: drop support for "force" unmount option The "force" unmount option has been deprecated and ignored (CL:388592, chromium:646224). CrosDisksClient on the chrome side has been updated to stop using the "force" option (crrev.com/2743113003). platform_CrosDisks* autotests have also been updated accordingly (CL:452957). We can now remove support for the "force" unmount option from cros-disks. BUG= chromium:700548 CQ-DEPEND=CL:452957 TEST=Run unit tests. TEST=Run platform_CrosDisks* autotests. TEST=Manually mount and unmount an external USB drive via Files.app. Change-Id: Ifd64e468a9303e591515e1d5520854c6c8f8169f Reviewed-on: https://chromium-review.googlesource.com/452863 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/mount_manager_unittest.cc [modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/mount_manager.cc [modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/disk_manager.cc
,
Mar 20 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 11 2017