New issue
Advanced search Search tips

Issue 700548 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros-disks: remove "force" option for unmount

Project Member Reported by benchan@chromium.org, Mar 10 2017

Issue description

This is a follow-up on chromium:646224, which we deprecated the "force" option in the cros-disks's Unmmount DBus API. We should update chrome's cros_disks_client to stop using the "force" option, and then update cros-disks to fully remove the option.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bcaea14967dab3bbfd0a13ccbb567c70614f149

commit 8bcaea14967dab3bbfd0a13ccbb567c70614f149
Author: benchan <benchan@chromium.org>
Date: Sat Mar 11 00:26:50 2017

Stop passing "force" option when invoking cros-disks's Unmount method.

cros-disks's Unmount method now ignores the "force" option (CL:388592,
chromium:646224). This CL updates CrosDisksClient to stop passing the
"force" option when invoking the Unmount method.

BUG= 700548 
TEST=chromos_unittests

Review-Url: https://codereview.chromium.org/2743113003
Cr-Commit-Position: refs/heads/master@{#456230}

[modify] https://crrev.com/8bcaea14967dab3bbfd0a13ccbb567c70614f149/chromeos/dbus/cros_disks_client.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203

commit c5ff288ad5a1cb8a4d80d3babf302f6db70fe203
Author: Ben Chan <benchan@chromium.org>
Date: Sat Mar 11 03:52:32 2017

Use lazy umount instead of force unmount in cros-disks tests.

The "force" unmount option has been deprecated and ignored by cros-disks
(CL:388592, chromium:646224). This CL updates the
platform_CrosDisksArchive and platform_CrosDisksFilesystem test to use
the "lazy" unmount option instead.

BUG= chromium:700548 
TEST=Run platform_CrosDisksArchive and platform_CrosDisksFilesystem.

Change-Id: I79b104613c97d8f937e5e1a4dfde149ddad55a27
Reviewed-on: https://chromium-review.googlesource.com/452957
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203/client/site_tests/platform_CrosDisksFilesystem/platform_CrosDisksFilesystem.py
[modify] https://crrev.com/c5ff288ad5a1cb8a4d80d3babf302f6db70fe203/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/97bc80607220003de53fa8f34ff2fdf45adf1579

commit 97bc80607220003de53fa8f34ff2fdf45adf1579
Author: Ben Chan <benchan@chromium.org>
Date: Sat Mar 18 03:12:20 2017

cros-disks: drop support for "force" unmount option

The "force" unmount option has been deprecated and ignored (CL:388592,
chromium:646224). CrosDisksClient on the chrome side has been updated to
stop using the "force" option (crrev.com/2743113003).
platform_CrosDisks* autotests have also been updated accordingly
(CL:452957). We can now remove support for the "force" unmount option
from cros-disks.

BUG= chromium:700548 
CQ-DEPEND=CL:452957
TEST=Run unit tests.
TEST=Run platform_CrosDisks* autotests.
TEST=Manually mount and unmount an external USB drive via Files.app.

Change-Id: Ifd64e468a9303e591515e1d5520854c6c8f8169f
Reviewed-on: https://chromium-review.googlesource.com/452863
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/mount_manager_unittest.cc
[modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/mount_manager.cc
[modify] https://crrev.com/97bc80607220003de53fa8f34ff2fdf45adf1579/cros-disks/disk_manager.cc

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment