MD Settings: Should not show subpage animations on direct navigation |
|||||||||||
Issue descriptionRepro: 1) Load any subpage URL directly, for example chrome://md-settings/searchEngines 2) Observe fade-in animation (see attachment) The animation is unnecessary. It makes the page flicker and also delays the user from getting where they want to go faster.
,
Mar 10 2017
,
Mar 10 2017
,
Mar 13 2017
,
Apr 18 2017
,
Apr 19 2017
I made an experimental CL here: https://codereview.chromium.org/2825203003/ For minimum code change, a very brief delay still exists (due to how the subpages are placed inside the section). An alternative suggested by dpapad@ is to overhaul how we do views. In short, have some sort of view-stack manager, and each subpage would not be a child of a section but still animates in when called upon. This approach would also fix other tech debt such as scrolling issues, but would take quite some effort and time. dbeam@ please see attached video and let me know if you think the visual is acceptable for the purpose of this bug, or if we should spend the effort to overhaul how we show views.
,
May 4 2017
tbuckley@ & bettes@: So we've made and iterated on a CL that would remove the animation and make the load appear more snappy, but it is adding some logic to an area in the code-base that is more complex than we'd like to maintain in the long run. So before we dive too deep into cleaning up the code, could you help answer this: is this actually something we want to fix at all? Would people want to see the subpage immediately when they land on it directly, or do they actually prefer to see the animation every time like it does now? (Just want to emphasize again, this is only for when you land on the subpage url *directly*)
,
May 4 2017
IMO: no, of course we don't want to show animations when going directly to a page; they serve no real purpose. this is what the old settings page does (turns off animations while loading).
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d84ddac6a6b61604f0057ccb8046144287f795ec commit d84ddac6a6b61604f0057ccb8046144287f795ec Author: scottchen <scottchen@chromium.org> Date: Wed May 31 22:21:31 2017 Experiment to remove subpage animation when landing directly on it. BUG= 700547 , 722790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825203003 Cr-Commit-Position: refs/heads/master@{#476060} [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/test/data/webui/settings/settings_main_test.js
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d84ddac6a6b61604f0057ccb8046144287f795ec commit d84ddac6a6b61604f0057ccb8046144287f795ec Author: scottchen <scottchen@chromium.org> Date: Wed May 31 22:21:31 2017 Experiment to remove subpage animation when landing directly on it. BUG= 700547 , 722790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825203003 Cr-Commit-Position: refs/heads/master@{#476060} [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/d84ddac6a6b61604f0057ccb8046144287f795ec/chrome/test/data/webui/settings/settings_main_test.js
,
May 31 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dpa...@chromium.org
, Mar 10 2017374 KB
374 KB View Download