New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700537 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

record EffectiveConnectionType in UKM at navigation start

Project Member Reported by bmcquade@chromium.org, Mar 10 2017

Issue description

We want to record EffectiveConnectionType in UKM at navigation start
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1401b43ed20688607c38be6e012f9310badf3f2d

commit 1401b43ed20688607c38be6e012f9310badf3f2d
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Mar 10 23:54:18 2017

Persist EffectiveConnectionType in UKM on navigation start.

This change emits a UKM PageLoad metric for the EffectiveConnectionType
observed at navigation start.

This change also corrects an issue where we logged some information in
OnStart. When OnStart is invoked, we don't yet know if we're observing
a page load, so we move all logging to later in the flow, when we know
we're observing a page load.

BUG= 700537 

Review-Url: https://codereview.chromium.org/2740403002
Cr-Commit-Position: refs/heads/master@{#456219}

[modify] https://crrev.com/1401b43ed20688607c38be6e012f9310badf3f2d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/1401b43ed20688607c38be6e012f9310badf3f2d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/1401b43ed20688607c38be6e012f9310badf3f2d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/1401b43ed20688607c38be6e012f9310badf3f2d/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 13 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829838488f6690b59944b5f83d427f012b316cc9

commit 829838488f6690b59944b5f83d427f012b316cc9
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Mar 13 15:38:21 2017

Persist EffectiveConnectionType in UKM on navigation start.

This change emits a UKM PageLoad metric for the EffectiveConnectionType
observed at navigation start.

This change also corrects an issue where we logged some information in
OnStart. When OnStart is invoked, we don't yet know if we're observing
a page load, so we move all logging to later in the flow, when we know
we're observing a page load.

BUG= 700537 
NOTRY=true
NOPRESUBMIT=true
TBR=tbansal

Review-Url: https://codereview.chromium.org/2740403002
Cr-Commit-Position: refs/heads/master@{#456219}
(cherry picked from commit 1401b43ed20688607c38be6e012f9310badf3f2d)

Review-Url: https://codereview.chromium.org/2749553002
Cr-Commit-Position: refs/branch-heads/3029@{#150}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/829838488f6690b59944b5f83d427f012b316cc9/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/829838488f6690b59944b5f83d427f012b316cc9/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/829838488f6690b59944b5f83d427f012b316cc9/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/829838488f6690b59944b5f83d427f012b316cc9/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Status: Fixed (was: Started)

Sign in to add a comment