Site Isolation Win FYI bot failing fast/dnd/dropEffect-for-effectAllowed.html test |
||
Issue descriptionSince r454488 landed, the dropEffect-for-effectAllowed.html test has been failing when run with --site-per-process on the Site Isolation Win FYI bot: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/18203 https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/18269 Backlog: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win?numbuilds=200 There have been a handful of successful runs in there, but most fail by timing out. Oddly, I'm not able to repro locally, at least on Linux: DISPLAY=:20 Tools/Scripts/run-webkit-tests -t Default -v --additional-drt-flag=--site-per-process --no-retry-failures --additional-drt-flag=--no-sandbox --iterations=10 fast/dnd/dropEffect-for-effectAllowed.html pwnall@: Do you know what might be going wrong here? Can you update the test or disable it on this bot in third_party/WebKit/LayoutTests/FlagExpectations/site-per-process?
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0d5ce517c3a43de2eee4e8bd616d2d85ff1a7f9 commit c0d5ce517c3a43de2eee4e8bd616d2d85ff1a7f9 Author: creis <creis@chromium.org> Date: Tue Mar 14 02:00:51 2017 Update test expectation for dropEffect-for-effectAllowed.html BUG= 700535 TEST=Site Isolation Win FYI bot goes green. NOTRY=true Review-Url: https://codereview.chromium.org/2746323002 Cr-Commit-Position: refs/heads/master@{#456568} [modify] https://crrev.com/c0d5ce517c3a43de2eee4e8bd616d2d85ff1a7f9/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Mar 28 2017
I just ran into this (Chrome 56.0.2924.87 64-bit, Linux) in the wild trying to figure out how `effectAllowed` works. When I try to drag something around inside the editable text in the example below, nothing happens and the scripted drop handler is never called. So that seems like a rather serious bug.
```
<!DOCTYPE html><meta charset="utf-8">
<div contenteditable=true><p>foo bar baz</p><p>foo bar baz</p></div>
<script>
document.querySelector("div").addEventListener("drop", e => {
console.log("drop event w/", e.dataTransfer.dropEffect)
})
document.querySelector("div").addEventListener("dragstart", e => {
e.dataTransfer.effectAllowed = "copy"
})
</script>
```
,
Mar 28 2017
#3: This issue is about a test that covers drag-and-drop, not about the drag-and-drop implementation itself. Please file a new issue describing your problem. Following the new issue template will help you give us crucial information such as a specific set of steps, what exactly you expect to happen, and how other browsers behave in this situation.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62db39d8dec89187c2518d0046b7ca28d9fc747d commit 62db39d8dec89187c2518d0046b7ca28d9fc747d Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 23:23:03 2017 Disable exceptions for tests that have "healed" themselves. Bug: 758075 , 700535 , 582522 , 602497 , 616905 Bug: 623268 , 623265 , 678492 Change-Id: I1bdc648c9aeb97cc1d16b0d8693d04e0c76030de Reviewed-on: https://chromium-review.googlesource.com/700983 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506557} [modify] https://crrev.com/62db39d8dec89187c2518d0046b7ca28d9fc747d/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Oct 5 2017
Both Site Isolation FYI bots are green - tentatively closing this as fixed. Please reopen if the issue happens again. |
||
►
Sign in to add a comment |
||
Comment 1 by pwnall@chromium.org
, Mar 10 2017