Issue metadata
Sign in to add a comment
|
Extra fields don't show up in memory dump overview pane. |
||||||||||||||||||||||||
Issue descriptionWe emit a metric called private_bytes: https://cs.chromium.org/chromium/src/components/tracing/common/process_metrics_memory_dump_provider.cc?type=cs&q=GetWorkingSetSize+package:%5Echromium$&l=633 That's behind an if statement, I tried adding it unconditionally and nothing changed. I also tried adding a field with a random name "owiehf" and that didn't show up either. Supposed the string gets changed to "Private": https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/ui/analysis/memory_dump_overview_pane.html?type=cs&q=private_bytes+package:%5Echromium$&l=622 But I don't see it in the resulting trace.
,
Mar 10 2017
In process_metrics_memory_dump_provider, #elif defined(MACOSX) should be #elif defined(OS_MACOSX).
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1 commit 56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1 Author: erikchen <erikchen@chromium.org> Date: Mon Mar 13 22:46:49 2017 mac: Fix calulation for resident size of a process. The previous implementation of GetWorkingSetSize used task_info(TASK_BASIC_INFO_64), which returns the number of resident pages in the pmap for the vm subsystem for the process. This fails to correctly account for resident pages of copy-on-write and shared memory memory regions, as the pages might be mapped by the pmap for another process. In passing, this CL fixes a typo in process_metrics_memory_dump_provider.cc, which used defined(MACOSX) instead of defined(OS_MACOSX). BUG= 700532 , 693263 Review-Url: https://codereview.chromium.org/2740423002 Cr-Commit-Position: refs/heads/master@{#456514} [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics.h [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics_freebsd.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics_linux.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics_mac.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics_openbsd.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/base/process/process_metrics_win.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/chrome/browser/task_manager/sampling/task_group_sampler.cc [modify] https://crrev.com/56722415bddf6b1eb88f6e7fb9e9d4df7f21b9a1/components/tracing/common/process_metrics_memory_dump_provider.cc
,
Mar 20 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ssid@chromium.org
, Mar 10 2017