DevTools: make conditional breakpoints more powerful |
||||||||||||||||||
Issue descriptionMetabug, paste links here.
,
Mar 10 2017
links: https://coderwall.com/p/ylrgjg/log-messages-with-xcode-breakpoints https://msdn.microsoft.com/en-us/library/5557y8b4(v=vs.110).aspx https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Set_a_conditional_breakpoint some screenshots attached
,
Sep 21 2017
,
Oct 16 2017
,
Sep 28
Erik, you showed cool demos of nicer conditional breakpoints, please take a look on screenshots here.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe1c04b129ef3df24807ccb312ec3b97483c0b5c commit fe1c04b129ef3df24807ccb312ec3b97483c0b5c Author: Erik Luo <luoe@chromium.org> Date: Wed Nov 21 19:31:46 2018 DevTools: extract breakpoint condition editor Bug: 700519 Change-Id: I85553324c653f7397ed538581dc62ac5260188fe Reviewed-on: https://chromium-review.googlesource.com/c/1329900 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#610158} [modify] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/BUILD.gn [add] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/front_end/sources/BreakpointEditDialog.js [modify] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js [add] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/front_end/sources/breakpointEditDialog.css [modify] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/front_end/sources/module.json [modify] https://crrev.com/fe1c04b129ef3df24807ccb312ec3b97483c0b5c/third_party/blink/renderer/devtools/front_end/sources/sourcesView.css
,
Nov 28
I currently have a CL in review that adds a DevTools experiment: - "Add logpoint..." context menu option added when right-clicking gutter - Breakpoint editor visually has only one border, no rounded corners - Breakpoint editor has type switching dropdown, allowing users to switch to logpoint/conditional breakpoint/breakpoint (switching to normal breakpoint also closes the editor) Here's a screenshot: https://imgur.com/a/10S4buB Behavior of the editor/switching should resemble that of other editors. Please take a look, Julia, Hwi
,
Dec 1
Thanks Erik. Has it landed on Canary recently?
,
Dec 3
Not yet. The CL in comment #6 updates the code in place to prepare, so there is still time to update the UI if we wish, or make this a default experiment if we are confident. I have 2 more CLs to land which - introduces an experiment https://chromium-review.googlesource.com/c/chromium/src/+/1330079 - updates editor UI to the screenshot in #7 https://chromium-review.googlesource.com/c/chromium/src/+/1344919
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/098da25c94fcb874ef01f853e7cb11f3759aabc8 commit 098da25c94fcb874ef01f853e7cb11f3759aabc8 Author: Erik Luo <luoe@chromium.org> Date: Mon Dec 03 20:35:06 2018 DevTools: introduce basic logpoint experiment Behind an experiment, a new context menu option in the Sources gutter allows adding a logpoint. Future CLs will tackle editing a breakpoint type and UI changes. Logpoints `console.log` a message instead of pausing. Bug: 700519 Change-Id: Ib33c1a84de4fbc06b6fde6e2e3dd7628e3896d64 Reviewed-on: https://chromium-review.googlesource.com/c/1330079 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#613223} [modify] https://crrev.com/098da25c94fcb874ef01f853e7cb11f3759aabc8/third_party/blink/renderer/devtools/front_end/main/Main.js [modify] https://crrev.com/098da25c94fcb874ef01f853e7cb11f3759aabc8/third_party/blink/renderer/devtools/front_end/sources/BreakpointEditDialog.js [modify] https://crrev.com/098da25c94fcb874ef01f853e7cb11f3759aabc8/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js [add] https://crrev.com/098da25c94fcb874ef01f853e7cb11f3759aabc8/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-logpoint-expected.txt [add] https://crrev.com/098da25c94fcb874ef01f853e7cb11f3759aabc8/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-logpoint.js
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a2d091d43212bce947b34c824813dc6fbeadb48 commit 3a2d091d43212bce947b34c824813dc6fbeadb48 Author: Erik Luo <luoe@chromium.org> Date: Sat Dec 08 05:55:22 2018 DevTools: update breakpoint editor UI Initial, basic UI for switching between breakpoint types. Bug: 700519 Change-Id: Ic2c6fe2e0608ca481f0f32861d6c12ec8fbd619e Reviewed-on: https://chromium-review.googlesource.com/c/1344919 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#614954} [modify] https://crrev.com/3a2d091d43212bce947b34c824813dc6fbeadb48/third_party/blink/renderer/devtools/front_end/sources/BreakpointEditDialog.js [modify] https://crrev.com/3a2d091d43212bce947b34c824813dc6fbeadb48/third_party/blink/renderer/devtools/front_end/sources/breakpointEditDialog.css [modify] https://crrev.com/3a2d091d43212bce947b34c824813dc6fbeadb48/third_party/blink/renderer/devtools/front_end/text_editor/CodeMirrorTextEditor.js [modify] https://crrev.com/3a2d091d43212bce947b34c824813dc6fbeadb48/third_party/blink/renderer/devtools/front_end/ui/TextEditor.js
,
Dec 11
Erik, could you let us know once this has landed in Canary so we can test? Thanks
,
Dec 11
This has landed in Canary, please take a look! It is behind the "Sources: logpoints" experiment
,
Dec 20
Based on an offline discussion: Screenshot of iteration: https://imgur.com/a/OVrZW2j Trying to get the editor to take up the visible viewport width was tricky... CodeMirror keeps decorations within each line's element, so there is no straightforward way to achieve this. Instead, we can add max-width and min-width and allow it to stretch in between. After pretty-printing a source, we are sometimes unable to open the breakpoint dialog. This is a separate issue that needs investigation.
,
Dec 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/046112da39a7a9ec0c14ada2fa541ba731964a18 commit 046112da39a7a9ec0c14ada2fa541ba731964a18 Author: Erik Luo <luoe@chromium.org> Date: Sat Dec 22 21:46:37 2018 DevTools: iterate and enable logpoints experiment Enables the experiment by default and iterates on the visual styles. Screenshot: https://imgur.com/a/VTucPwP Bug: 700519 Change-Id: I392657274d8fe59a90ed4984ac22b658c79ccbae Reviewed-on: https://chromium-review.googlesource.com/c/1385426 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#618766} [modify] https://crrev.com/046112da39a7a9ec0c14ada2fa541ba731964a18/third_party/blink/renderer/devtools/front_end/main/Main.js [modify] https://crrev.com/046112da39a7a9ec0c14ada2fa541ba731964a18/third_party/blink/renderer/devtools/front_end/sources/BreakpointEditDialog.js [modify] https://crrev.com/046112da39a7a9ec0c14ada2fa541ba731964a18/third_party/blink/renderer/devtools/front_end/sources/breakpointEditDialog.css |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by pfeldman@chromium.org
, Mar 10 2017