New issue
Advanced search Search tips

Issue 700518 link

Starred by 2 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Oct 2017
Cc:
sky@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Downgrade CHECK in TabStripModel::SetOpenerOfWebContentsAt

Project Member Reported by rdevlin....@chromium.org, Mar 10 2017 
revision d6234406958a28d55dab50e42137b6c32851451e added a CHECK in TabStripModel::SetOpenerOfWebContentsAt() that the tab strip model owns the added web contents.  This was because this recently caused a bad bug (issue 698681), and we want to make sure that we've caught all the cases when this can happen.

Once we're reasonably certain we have, we should downgrade the CHECK to a DCHECK.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37536a9826c835e985d035d89f0b385236361a3

commit b37536a9826c835e985d035d89f0b385236361a3
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Oct 05 01:28:57 2017

[Cleanup] Downgrade CHECK to DCHECK in TabStripModel

This CHECK was added to (help) ensure we tracked down the cases when
we were trying to set an invalid opener. It's been a few cycles, and we
haven't seen any crashes, so downgrade to a DCHECK.

Bug:  700518 
Change-Id: I3f607fe4ae7b98bbaac30fa910c0bf7394388270
Reviewed-on: https://chromium-review.googlesource.com/693309
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506611}
[modify] https://crrev.com/b37536a9826c835e985d035d89f0b385236361a3/chrome/browser/ui/tabs/tab_strip_model.cc

Comment 2 by rdevlin....@chromium.org, Oct 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment