New issue
Advanced search Search tips

Issue 700486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Preserve use stats of existing Wallet cards when syncing.

Project Member Reported by se...@chromium.org, Mar 10 2017

Issue description

Also make sure that a delayed sync of metadata will be able to take effect. This is because new Wallet sync get the use_date set to now, which is not be overwritten with the metadata sync currently.
 

Comment 1 by se...@chromium.org, Mar 10 2017

For context, When Wallet syncs, all cards get replaced. Because of that, all their use_date were set to "now" at every sync.

Now Load the use stats from disk if possible.

Also for new Chromium instance where the is nothing on disk, added logic to keep use_date from metadata sync if the local version has never been used.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2017

Comment 3 by se...@chromium.org, Mar 20 2017

Labels: Merge-Request-58
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 20 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 20 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18

commit c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18
Author: sebsg <sebsg@chromium.org>
Date: Mon Mar 20 19:26:40 2017

[Merge-58] Preserve use stats of existing Wallet cards when syncing.

Load the use stats from disk when saving Wallet Cards.

Add specific logic to overwrite a Wallet card use data in case the
metadata gets delayed. The previous logic was keep most recent which
resulted in making old card seem like they were just used.

BUG= 700486 

Review-Url: https://codereview.chromium.org/2741233002
Cr-Commit-Position: refs/heads/master@{#456395}
(cherry picked from commit 109e10b0a48a1f09d242562611c2556b12a29da6)

Review-Url: https://codereview.chromium.org/2759183003 .
Cr-Commit-Position: refs/branch-heads/3029@{#308}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
[modify] https://crrev.com/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
[modify] https://crrev.com/c558a4c40f4b3dd67cc6f50a879bc1f6e16fbe18/components/autofill/core/browser/webdata/autofill_wallet_syncable_service_unittest.cc

Comment 6 by se...@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Sign in to add a comment