My local browser_tests build failed like so:

thakis-macpro:src thakis$ ninja -C out/gnasan browser_tests -j200
ninja: Entering directory `out/gnasan'
[969/10214] CXX obj/apps/test_support/app_window_waiter.o
FAILED: obj/apps/test_support/app_window_waiter.o 
export DEVELOPER_DIR=/Users/thakis/src/chrome/src/build/mac_files/Xcode.app;  /Users/thakis/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/apps/test_support/app_window_waiter.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DDISABLE_NACL -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_IGNORE_DW_GRAY_FIX -DSK_LEGACY_FONTMGR_FACTORY -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -gdwarf-2 -fno-standalone-debug -isysroot /Users/thakis/src/chrome/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../apps/test/app_window_waiter.cc -o obj/apps/test_support/app_window_waiter.o
In file included from ../../apps/test/app_window_waiter.cc:7:
In file included from ../../extensions/browser/app_window/app_window.h:21:
In file included from ../../extensions/browser/extension_function_dispatcher.h:13:
In file included from ../../extensions/browser/extension_function.h:25:
In file included from ../../extensions/browser/info_map.h:15:
In file included from ../../extensions/common/extension_set.h:18:
../../extensions/common/extension.h:23:10: fatal error: 'extensions/features/features.h' file not found
#include "extensions/features/features.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.



On the second build, everything was happy.


Looks like that features.h header is fairly new. Since it's included in a public header, https://codereview.chromium.org/2479593006/diff/200001/chrome/browser/extensions/BUILD.gn should've probably touched public_deps, not deps.