Remove third-party Android payment apps enable/disable toggle |
|||||
Issue description^^^
,
Mar 10 2017
Shall we change the text "On some websites, you can pay with supported payment apps. Choose which apps to use in Chrome." to "On some websites, you can pay with supported payment apps." or others or simply remove it?
,
Mar 10 2017
,
Mar 13 2017
If you can't change the setting, I don't think it's worth including it. I'd vote for removal.
,
Mar 13 2017
Removal gets my vote as well,
,
Mar 13 2017
Here is new screenshot without the text,
,
Mar 13 2017
Oh, I actually meant removing the entire section, since we UI Review unfortunately didn't approve the addition of settings. zkoch@, thoughts?
,
Mar 13 2017
Oh, I think this is fine. UI review was okay with a list.
,
Mar 13 2017
Sorry for the confusion. In that case I think it's worth keeping copy along the lines of "On some websites, you can pay with supported payment apps installed on your device."
,
Mar 13 2017
Okay, here is a screenshot of the screen with update text, What about the text: "On some websites, you can pay with above supported payment apps on your device."
,
Mar 13 2017
I think that works great.
,
Mar 13 2017
Okay, updated the text, CL is out for review,
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/320588fcc48f1e0419ad64e36f55eb5f508c3298 commit 320588fcc48f1e0419ad64e36f55eb5f508c3298 Author: gogerald <gogerald@chromium.org> Date: Tue Mar 14 22:00:25 2017 Remove toggle of Android payment apps in settings BUG= 700480 Review-Url: https://codereview.chromium.org/2748793003 Cr-Commit-Position: refs/heads/master@{#456853} [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/ui/android/BUILD.gn [add] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/ui/android/java/src/org/chromium/ui/HorizontalListDividerDrawable.java
,
Mar 14 2017
,
Apr 6 2017
Tested on 59.0.3062.4 build and attached testing screenshot
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc9e95817ed4033644e3556920805ff14088c3e1 commit bc9e95817ed4033644e3556920805ff14088c3e1 Author: gogerald <gogerald@chromium.org> Date: Wed Apr 26 17:54:08 2017 Remove redundant string BUG= 700480 Review-Url: https://codereview.chromium.org/2842063004 Cr-Commit-Position: refs/heads/master@{#467376} [modify] https://crrev.com/bc9e95817ed4033644e3556920805ff14088c3e1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rouslan@chromium.org
, Mar 10 2017