New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700480 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Remove third-party Android payment apps enable/disable toggle

Project Member Reported by gogerald@chromium.org, Mar 10 2017

Issue description

^^^

 
Summary: Remove third-party Android payment apps enable/disable toggle (was: Remove third-party Android payment apps flag)
Shall we change the text "On some websites, you can pay with supported payment apps. Choose which apps to use in Chrome." to "On some websites, you can pay with supported payment apps." or others or simply remove it?
Cc: bbergher@chromium.org zkoch@chromium.org
If you can't change the setting, I don't think it's worth including it. I'd vote for removal.
Removal gets my vote as well,
Here is new screenshot without the text,
Screenshot_2017-03-13-13-50-04.png
52.5 KB View Download
Oh, I actually meant removing the entire section, since we UI Review unfortunately didn't approve the addition of settings.

zkoch@, thoughts?

Comment 8 by zkoch@chromium.org, Mar 13 2017

Oh, I think this is fine. UI review was okay with a list.
Sorry for the confusion. In that case I think it's worth keeping copy along the lines of "On some websites, you can pay with supported payment apps installed on your device." 
Okay, here is a screenshot of the screen with update text,

What about the text: "On some websites, you can pay with above supported payment apps on your device."
Screenshot_2017-03-13-14-37-59.png
88.4 KB View Download
I think that works great.
Okay, updated the text, CL is out for review,
Screenshot_2017-03-13-15-11-29.png
85.9 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320588fcc48f1e0419ad64e36f55eb5f508c3298

commit 320588fcc48f1e0419ad64e36f55eb5f508c3298
Author: gogerald <gogerald@chromium.org>
Date: Tue Mar 14 22:00:25 2017

Remove toggle of Android payment apps in settings

BUG= 700480 

Review-Url: https://codereview.chromium.org/2748793003
Cr-Commit-Position: refs/heads/master@{#456853}

[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/ui/android/BUILD.gn
[add] https://crrev.com/320588fcc48f1e0419ad64e36f55eb5f508c3298/ui/android/java/src/org/chromium/ui/HorizontalListDividerDrawable.java

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Tested on 59.0.3062.4 build and attached testing screenshot
payments.png
37.9 KB View Download
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment