New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700476 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

metrics::MetricsService::RecordCurrentStabilityHistograms() takes 45ms on startup

Project Member Reported by asvitk...@chromium.org, Mar 10 2017

Issue description

metrics::MetricsService::RecordCurrentStabilityHistograms() takes 45ms:

https://uma.googleplex.com/callstacks?sid=56e3f54241e558070e210f56b036a54c

This is on Windows dev and likely caused by IO from reading the files.

We should move this to a background thread.
 
Is this always, or only after an unclean shutdown?  After a clean shutdown, these should be only a single stat() call that notices that the file doesn't exist; that shouldn't take 45ms.

Are there background threads at that time?

Also, aren't the stability metrics collected right at start-up, meaning that it would still block waiting for a background thread to complete?

This is the aggregate mean. Which means for runs where the function takes no time the value will be 0 but there's sufficient users who do take time in that function that it still averages out to 45ms per startup.
Status: WontFix (was: Available)
MetricsService::RecordCurrentStabilityHistograms no longer shows up in sampling profiler. Closing. (This makes sense because we no longer read files in that function.)

Sign in to add a comment