Touch events on a flinging layer are still cancelable! |
||
Issue descriptionGot the exact same result on 3 different Chrome Versions on Android: ToT (59.0.3034.0), dev (58.0.3029.11), stable (56.0.2924.87) Also saw the same result in a recent (~a week old) CrOS build. Repro steps: Open output.jsbin.com/begolep. Then do two quick upward flings, the second one should start while the first one is on-going. (Ignore all pointer events except pointercancel in the log.) What is the expected result? All touch events after the first pointercancel (the start of fling) should NOT be marked with a "c" (meaning "cancelable"). What happens instead of that? The touch events from the second touchstart event are marked as cancelable.
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9327ce925b77f722c31116f5e08cff23df70908d commit 9327ce925b77f722c31116f5e08cff23df70908d Author: lanwei <lanwei@chromium.org> Date: Wed Mar 29 16:27:27 2017 Make sure all the touch events during an active fling are uncancelable After we enabled the fling intervention, all the touch events during an active fling should be uncancelable, but now they are still cancelable. The reason is the layer returned by FindLayerThatIsHitByPointInTouchHandlerRegion does not match with the current scrolling layer even we scroll on the same layer. So, we use FindLayerThatIsHitByPoint to return the layer the touch start hits on and compare with the current scrolling layer. BUG= 700465 Review-Url: https://codereview.chromium.org/2759523002 Cr-Commit-Position: refs/heads/master@{#460415} [modify] https://crrev.com/9327ce925b77f722c31116f5e08cff23df70908d/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/9327ce925b77f722c31116f5e08cff23df70908d/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/9327ce925b77f722c31116f5e08cff23df70908d/cc/trees/layer_tree_host_impl_unittest.cc
,
Aug 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by lanwei@chromium.org
, Mar 13 2017