Code that checks if previews are enabled or checks the previews version should be moved to a layer that can read from other components. The result can be injected into previews_io_data/previews_blacklist_sql_store.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e69df7ab2555ce8874972c419b13add8e0ec0c32 commit e69df7ab2555ce8874972c419b13add8e0ec0c32 Author: ryansturm <ryansturm@chromium.org> Date: Mon Mar 13 22:41:59 2017 Moving previews code from components/ to chrome/ Allows support for looking in other components or chrome code to verify if a preview is enabled and check the previews version. The layering dynamic is that components such as d_r_p will depend on previews/ and not the other way around, so these methods should be moved to chrome/ and relevant information should be injected. BUG= 700459 Review-Url: https://codereview.chromium.org/2739033005 Cr-Commit-Position: refs/heads/master@{#456511} [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/chrome/browser/previews/previews_service.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_experiments.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_experiments.h [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_experiments_unittest.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_io_data.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_io_data.h [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_io_data_unittest.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_opt_out_store_sql.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_opt_out_store_sql.h [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_opt_out_store_sql_unittest.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_ui_service.cc [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_ui_service.h [modify] https://crrev.com/e69df7ab2555ce8874972c419b13add8e0ec0c32/components/previews/core/previews_ui_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/079434a138a811058137ee9dfb289e6155101cb9 commit 079434a138a811058137ee9dfb289e6155101cb9 Author: yoichio <yoichio@chromium.org> Date: Tue Mar 14 06:45:41 2017 Revert of Moving previews code from components/ to chrome/ (patchset #4 id:60001 of https://codereview.chromium.org/2739033005/ ) Reason for revert: Builders this step failed on: Linux Tests [17 since first detection] 1 test failed: LoadAndLaunchExtensionBrowserTest.LoadAndLaunchExtension Since: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/53070 Original issue's description: > Moving previews code from components/ to chrome/ > > Allows support for looking in other components or chrome code to verify > if a preview is enabled and check the previews version. The layering > dynamic is that components such as d_r_p will depend on previews/ and > not the other way around, so these methods should be moved to chrome/ > and relevant information should be injected. > > BUG= 700459 > > Review-Url: https://codereview.chromium.org/2739033005 > Cr-Commit-Position: refs/heads/master@{#456511} > Committed: https://chromium.googlesource.com/chromium/src/+/e69df7ab2555ce8874972c419b13add8e0ec0c32 TBR=tbansal@chromium.org,ryansturm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 700459 Review-Url: https://codereview.chromium.org/2748033002 Cr-Commit-Position: refs/heads/master@{#456640} [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/chrome/browser/previews/previews_service.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_experiments.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_experiments.h [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_experiments_unittest.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_io_data.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_io_data.h [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_io_data_unittest.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_opt_out_store_sql.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_opt_out_store_sql.h [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_opt_out_store_sql_unittest.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_ui_service.cc [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_ui_service.h [modify] https://crrev.com/079434a138a811058137ee9dfb289e6155101cb9/components/previews/core/previews_ui_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db539b8aaf2c0a5e3687f92dfba14a7036aa808f commit db539b8aaf2c0a5e3687f92dfba14a7036aa808f Author: ryansturm <ryansturm@chromium.org> Date: Wed Mar 15 02:13:57 2017 Moving previews code from components/ to chrome/ Allows support for looking in other components or chrome code to verify if a preview is enabled and check the previews version. The layering dynamic is that components such as d_r_p will depend on previews/ and not the other way around, so these methods should be moved to chrome/ and relevant information should be injected. BUG= 700459 Review-Url: https://codereview.chromium.org/2749693003 Cr-Commit-Position: refs/heads/master@{#456952} [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/chrome/browser/previews/previews_service.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_experiments.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_experiments.h [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_experiments_unittest.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_io_data.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_io_data.h [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_io_data_unittest.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_opt_out_store_sql.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_opt_out_store_sql.h [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_opt_out_store_sql_unittest.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_ui_service.cc [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_ui_service.h [modify] https://crrev.com/db539b8aaf2c0a5e3687f92dfba14a7036aa808f/components/previews/core/previews_ui_service_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Mar 13 2017