New issue
Advanced search Search tips

Issue 700451 link

Starred by 0 users
Status: Fixed
Owner:
b...@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

HTTP/2 pooling by IP address gets logged incorrectly after the first time

Project Member Reported by b...@chromium.org, Mar 10 2017 
When SpdySessionPool::FindAvailableSession() is called with a new SpdySessionKey and it finds an existing SpdySession with a different key but overlapping IP address and pooling happens, it correctly logs a HTTP2_SESSION_POOL_FOUND_EXISTING_SESSION_FROM_IP_POOL type NetLog event as well as a FOUND_EXISTING_FROM_IP_POOL value in the Net.SpdySessionGet histogram.

However, it adds a new entry to |available_sessions_| with the new SpdySessionKey.  Next time SpdySessionPool::FindAvailableSession() is called, LookupAvailableSessionByKey() finds the IP pooled session at [1], and the NetLog events and histogram value this time does not reflect the fact that the key is IP pooled again.

[1] https://cs.chromium.org/chromium/src/net/spdy/spdy_session_pool.cc?q=LookupAvailableSessionByKey&l=163
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e08dc7abfc81c398f35ad2eb6db7c492a9d06df

commit 0e08dc7abfc81c398f35ad2eb6db7c492a9d06df
Author: bnc <bnc@chromium.org>
Date: Fri Mar 10 21:27:51 2017

Correctly log IP pooling in SpdySessionPool.

Fix SpdySessionPool::FindAvailableSession() to log the correct
NetLog event type and the correct Net.SpdySessionGet histogram
value when pooling to an existing HTTP/2 connection by IP
address every time, not only the first time.

BUG= 700451 

Review-Url: https://codereview.chromium.org/2739183005
Cr-Commit-Position: refs/heads/master@{#456165}

[modify] https://crrev.com/0e08dc7abfc81c398f35ad2eb6db7c492a9d06df/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/0e08dc7abfc81c398f35ad2eb6db7c492a9d06df/net/spdy/spdy_session_pool_unittest.cc

Comment 2 by b...@chromium.org, Mar 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment