Issue metadata
Sign in to add a comment
|
Focus rectangle is broken on Launcher icon (Regression) |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 58.0.3029.12 (Official Build) dev (64-bit) Revision 0 Platform 9334.5.0 (Official Build) dev-channel link What steps will reproduce the problem? 1. Click Alt + Shift + L 2. Observe focus around launcher icon What happens? Focus rectangle is not aligned properly. Attached screenshot. This is a regression in M58. The same bug (https://bugs.chromium.org/p/chromium/issues/detail?id=683438) was earlier fixed and verified on M57. Issue not seen on latest M57 build 9202.51.0, 57.0.2987.100
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c582275b87cf75a5467d3afaa74e042baa553b38 commit c582275b87cf75a5467d3afaa74e042baa553b38 Author: xdai <xdai@chromium.org> Date: Tue Mar 14 16:44:56 2017 Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. The regression was introduced in https://codereview.chromium.org/2710053005. We need to make sure the canvas was restored right after the launcher circle icon was drawn. BUG= 700449 Review-Url: https://codereview.chromium.org/2746263002 Cr-Commit-Position: refs/heads/master@{#456730} [modify] https://crrev.com/c582275b87cf75a5467d3afaa74e042baa553b38/ash/common/shelf/app_list_button.cc
,
Mar 14 2017
,
Mar 14 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 14 2017
,
Mar 15 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb1e0b5de0215a7db18701045029503bf0d479be commit cb1e0b5de0215a7db18701045029503bf0d479be Author: xdai <xdai@chromium.org> Date: Mon Mar 20 16:47:37 2017 [Merge to M58]Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. The regression was introduced in https://codereview.chromium.org/2710053005. We need to make sure the canvas was restored right after the launcher circle icon was drawn. BUG= 700449 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2746263002 Cr-Commit-Position: refs/heads/master@{#456730} (cherry picked from commit c582275b87cf75a5467d3afaa74e042baa553b38) Review-Url: https://codereview.chromium.org/2763693002 . Cr-Commit-Position: refs/branch-heads/3029@{#298} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/cb1e0b5de0215a7db18701045029503bf0d479be/ash/common/shelf/app_list_button.cc
,
Mar 23 2017
9334.18.0 / 58.0.3029.31
,
Apr 24 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xiy...@chromium.org
, Mar 10 2017