New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700438 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 688263

Blocking:
issue 620034



Sign in to add a comment

Add support for Android Studio 2.3

Project Member Reported by estevenson@chromium.org, Mar 10 2017

Issue description

A few problems arise when upgrading from Android Studio 2.2 to 2.3 that need to be resolved before it will work properly.

Specifically:
  * An error shows that an updated version of build-tools is required (25 vs 24). This can be resolved by clicking the link in the error output to update the build tools version, but is annoying. This might be related to  issue 688263 .
  * Update gradle version to 3.3. Current is 2.3.3.
  * Certain files show errors because of missing dependencies (generally when a downstream class extends an upstream class). This might be a GN dependency problem, but it's more likely a problem with the generate_gradle.py script.
 

Comment 1 by wnwen@chromium.org, Mar 13 2017

Cc: -wnwen@chromium.org
Owner: wnwen@chromium.org
Status: Assigned (was: Available)
Finally! I'll fix these as they come up.

Comment 2 by wnwen@chromium.org, Mar 13 2017

Blockedon: 688263
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9fca7ca0225a5c4ef021046526bf75e2cade80d

commit f9fca7ca0225a5c4ef021046526bf75e2cade80d
Author: wnwen <wnwen@chromium.org>
Date: Wed Mar 15 15:47:29 2017

Android: Support Android Studio 2.3

Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.

BUG= 700438 

Review-Url: https://codereview.chromium.org/2746103004
Cr-Commit-Position: refs/heads/master@{#457093}

[modify] https://crrev.com/f9fca7ca0225a5c4ef021046526bf75e2cade80d/build/android/gradle/android.jinja
[modify] https://crrev.com/f9fca7ca0225a5c4ef021046526bf75e2cade80d/build/android/gradle/generate_gradle.py
[modify] https://crrev.com/f9fca7ca0225a5c4ef021046526bf75e2cade80d/build/android/gradle/root.jinja
[modify] https://crrev.com/f9fca7ca0225a5c4ef021046526bf75e2cade80d/docs/android_studio.md

There are still some issues when using 2.3 unfortunately:
  - AppHooks and friends seem to confuse Android Studio
  - SDK versioning problems: different errors arise when using internal SDK versions
  - "Cannot resolve symbol" errors (in many classes, don't see a pattern here)
  - Problems resolving generated enums from native
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/136f215ed31f9e748b388b5e79bf0e4888f62acc

commit 136f215ed31f9e748b388b5e79bf0e4888f62acc
Author: estevenson <estevenson@chromium.org>
Date: Fri Mar 17 19:59:19 2017

Revert of Android: Support Android Studio 2.3 (patchset #2 id:20001 of https://codereview.chromium.org/2746103004/ )

Reason for revert:
Breaks code editing in Android Studio, see http://crbug/700438 for more info.

Original issue's description:
> Android: Support Android Studio 2.3
>
> Also fixes excludes filters not working. For files whose directory is
> not fully included in the target, add those individually instead.
>
> BUG= 700438 
>
> Review-Url: https://codereview.chromium.org/2746103004
> Cr-Commit-Position: refs/heads/master@{#457093}
> Committed: https://chromium.googlesource.com/chromium/src/+/f9fca7ca0225a5c4ef021046526bf75e2cade80d

TBR=wnwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 700438 

Review-Url: https://codereview.chromium.org/2758683003
Cr-Commit-Position: refs/heads/master@{#457866}

[modify] https://crrev.com/136f215ed31f9e748b388b5e79bf0e4888f62acc/build/android/gradle/android.jinja
[modify] https://crrev.com/136f215ed31f9e748b388b5e79bf0e4888f62acc/build/android/gradle/generate_gradle.py
[modify] https://crrev.com/136f215ed31f9e748b388b5e79bf0e4888f62acc/build/android/gradle/root.jinja
[modify] https://crrev.com/136f215ed31f9e748b388b5e79bf0e4888f62acc/docs/android_studio.md

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2109641dd655c902d346ec9b3972b7519ee1da46

commit 2109641dd655c902d346ec9b3972b7519ee1da46
Author: estevenson <estevenson@chromium.org>
Date: Mon Mar 20 14:57:02 2017

Android: specify the supported version of Android Studio.

Now that 2.3 has been released, it will be the default version downloaded
by developers. //build/android/gradle/generate_gradle.py doesn't work
with 2.3 yet, and this should be reflected in our docs (we only support
2.2 currently).

BUG= 700438 

Review-Url: https://codereview.chromium.org/2758053002
Cr-Commit-Position: refs/heads/master@{#458060}

[modify] https://crrev.com/2109641dd655c902d346ec9b3972b7519ee1da46/docs/android_studio.md

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2017

Comment 8 by wnwen@chromium.org, Apr 5 2017

Status: Fixed (was: Assigned)

Comment 9 by wnwen@chromium.org, Apr 5 2017

Files with missing dependencies will be fixed separately (exact fix still TBD).

Sign in to add a comment