Run Android Studio Unused Declaration Inspection on Chromium |
||||
Issue descriptionJust gave this a test run: Analyze -> Run Inspection by Name. It found 6800 unused things! This is an exaggeration, as I didn't configure it quite right (need to restrict it to org.chromium, and need to ensure it knows about all test entry points). However, some spot checks revealed mostly legitimate dead code. It'd be worth the time to run through this I think.
,
Sep 13 2017
After hours of running, it found 6000+ unused things, after I pressed the filter button it promptly deleted everything and asked if I wanted to rerun... :) Lots of findings are legitimately unused parameters, but not sure how useful it is given proguard takes care of all those.
,
Sep 20 2017
Marking available as for now the overhead of running this O(hours) outweights benefits of removing a couple unused parameters. We'd need to incorporate a version of this into our build/compile step in order for its effects to keep.
,
Sep 21
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wnwen@chromium.org
, Sep 11 2017