For now the content suggestions are displayed in a separate screen. Move it to the NTP
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c commit 2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c Author: gambard <gambard@chromium.org> Date: Wed May 10 13:13:44 2017 Move frame-related methods out of GoogleLandingViewController In order to be able to display the ContentSuggestions as NTP, some methods should be moved in helpers. This CL moves the methods related to the frame of the elements in the NTP. BUG= 700375 , 717974 Review-Url: https://codereview.chromium.org/2857123003 Cr-Commit-Position: refs/heads/master@{#470549} [modify] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h [add] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [add] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm [modify] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/2c54e2be976f7c4e8d8ac2438f5f1e97f6566a6c/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/454efabee965715cf3a8ed20854455163cfc03b2 commit 454efabee965715cf3a8ed20854455163cfc03b2 Author: Gregory Chatzinoff <gchatz@chromium.org> Date: Tue Jun 20 21:24:00 2017 Revert "Add the header section to ContentSuggestions" This reverts commit ce6be2e5650b665a879b2150fee3fd3ca186f6b6. Reason for revert: This CL along with https://chromium-review.googlesource.com/c/536915/ broke a variety of external url tests on ipad 32-bit configs. Original change's description: > Add the header section to ContentSuggestions > > ContentSuggestions is supposed to replace the current NTP and display the logo > and the fake omnibox. > This CL adds the section which will contain the header to the content suggestions. > > Bug: 700375 > Change-Id: I4b9eac70b0464b3e289daf036323398b7704ba9f > Reviewed-on: https://chromium-review.googlesource.com/538693 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Louis Romero <lpromero@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480763} TBR=lpromero@chromium.org,gambard@chromium.org Change-Id: I4b6d25b4852428d73f077168cba57d302dd5ca8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 700375 Reviewed-on: https://chromium-review.googlesource.com/541760 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#480956} [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/content_suggestions/BUILD.gn [delete] https://crrev.com/00f82a9fe237df3f8c8d2db634df493b9699f83e/ios/chrome/browser/content_suggestions/content_suggestions_header_provider.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/content_suggestions/mediator_util.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [delete] https://crrev.com/00f82a9fe237df3f8c8d2db634df493b9699f83e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.h [delete] https://crrev.com/00f82a9fe237df3f8c8d2db634df493b9699f83e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.mm [delete] https://crrev.com/00f82a9fe237df3f8c8d2db634df493b9699f83e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item_unittest.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater_unittest.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm [modify] https://crrev.com/454efabee965715cf3a8ed20854455163cfc03b2/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc commit 7171792ed37b2a9548e5c7e4cd09432ec04bb9fc Author: gambard <gambard@chromium.org> Date: Thu Jun 22 06:32:48 2017 Reland of "Add the header section to ContentSuggestions" ContentSuggestions is supposed to replace the current NTP and display the logo and the fake omnibox. This CL adds the section which will contain the header to the content suggestions. Bug: 700375 Change-Id: I9d202c289519e3c8a5d8ce84a56d7d34f8fc6bd1 Reviewed-on: https://chromium-review.googlesource.com/543140 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#481465} [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/BUILD.gn [add] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/content_suggestions_header_provider.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/mediator_util.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [add] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.h [add] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.mm [add] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item_unittest.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater_unittest.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm [modify] https://crrev.com/7171792ed37b2a9548e5c7e4cd09432ec04bb9fc/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1080aff90a909e444902044d3f97c60c39bdd98 commit c1080aff90a909e444902044d3f97c60c39bdd98 Author: gambard <gambard@chromium.org> Date: Thu Jun 22 15:56:10 2017 Move NTPController to its own target When using ContentSuggestions in the NTP, the NTPController needs to include the ContentSuggestions and the ContentSuggestions includes the headers and protocol from ntp_internal. Splitting the target allows the includes. BUG= 700375 Change-Id: Ie6fe0d99a9fe6929efeb59d34bf772229af472e8 Reviewed-on: https://chromium-review.googlesource.com/544959 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#481547} [modify] https://crrev.com/c1080aff90a909e444902044d3f97c60c39bdd98/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c1080aff90a909e444902044d3f97c60c39bdd98/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/c1080aff90a909e444902044d3f97c60c39bdd98/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/c1080aff90a909e444902044d3f97c60c39bdd98/ios/chrome/test/app/BUILD.gn [modify] https://crrev.com/c1080aff90a909e444902044d3f97c60c39bdd98/ios/clean/chrome/browser/ui/ntp/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09c04f87d103c9f0cfdddfaf5b024168e2276df6 commit 09c04f87d103c9f0cfdddfaf5b024168e2276df6 Author: gambard <gambard@chromium.org> Date: Mon Jun 26 10:57:59 2017 Add controller for the Logo Header in ContentSuggestions This CL adds a controller, handling the creation and setup of the header view displayed on the Content Suggestions. Bug: 700375 Change-Id: Ib3f01b0ad873da29cbb1624323179ae9bdd9a05b Reviewed-on: https://chromium-review.googlesource.com/539337 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#482236} [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [add] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.h [add] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.mm [add] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_header_controller_delegate.h [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_header_provider.h [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/09c04f87d103c9f0cfdddfaf5b024168e2276df6/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50 commit 4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50 Author: gambard <gambard@chromium.org> Date: Mon Jun 26 15:13:53 2017 Add ContentSuggestions to the NTP panel. Replace the GoogleLandingViewController by ContentSuggestionsViewController when the suggestions flags is turned on. BUG= 700375 Change-Id: I8592c6c2fe39b1a646d807caa6b011afd2a9b7fa Reviewed-on: https://chromium-review.googlesource.com/548181 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#482279} [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.h [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.mm [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/4ce0336fa866cb6d1b7237f7c9d54db9aa6f4d50/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffc75d06488096bcc3a1e46feca4d78bc837c19b commit ffc75d06488096bcc3a1e46feca4d78bc837c19b Author: gambard <gambard@chromium.org> Date: Tue Jun 27 05:53:45 2017 Stick the omnibox to the top of the collection This CL adds a UICollectionFlowLayout to pin the omnibox to the top of the collection when scrolling down. Bug: 700375 Video: https://drive.google.com/open?id=0B21N-0pPGAuJdi0xVGVnVlFhWm8 Change-Id: I93d935bd380b787efc04b306b26a7ff2f958e6c7 Reviewed-on: https://chromium-review.googlesource.com/548378 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#482544} [modify] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [add] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.h [add] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [modify] https://crrev.com/ffc75d06488096bcc3a1e46feca4d78bc837c19b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7165eb8f640fe3e46e78da2cc070020d843f7d3e commit 7165eb8f640fe3e46e78da2cc070020d843f7d3e Author: gambard <gambard@chromium.org> Date: Wed Jun 28 14:20:55 2017 Add overscroll actions to ContentSuggestions As ContentSuggestions is now displayed on the NTP, the overscroll actions should be added. Video: https://drive.google.com/open?id=0B21N-0pPGAuJN1FKMVhFSGYyRkk Bug: 700375 Change-Id: I4c1345d09670cde0fce741400027d11cdaf0d386 Reviewed-on: https://chromium-review.googlesource.com/548497 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#482978} [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.h [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.mm [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [add] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_delegate.h [add] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_utils.h [add] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_utils.mm [add] https://crrev.com/7165eb8f640fe3e46e78da2cc070020d843f7d3e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_utils_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1985b53c2440fcd6ea123da4d0ddfb56d2726b2 commit e1985b53c2440fcd6ea123da4d0ddfb56d2726b2 Author: gambard <gambard@chromium.org> Date: Fri Jun 30 07:05:40 2017 Add toolbar shadow for ContentSuggestions ContentSuggestions is presented on the NTP. The NTP has a toolbar to navigate to Recent Tab and Bookmarks. A shadow has to be presented over the content if some is presented below the toolbar. BUG= 700375 Change-Id: Ib5683ebffcd2cd31202f9d425331f83e760df8e2 Reviewed-on: https://chromium-review.googlesource.com/555310 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#483647} [modify] https://crrev.com/e1985b53c2440fcd6ea123da4d0ddfb56d2726b2/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a90919df755b28d06305e1ecad9032322b054624 commit a90919df755b28d06305e1ecad9032322b054624 Author: gambard <gambard@chromium.org> Date: Mon Jul 03 10:38:05 2017 Add a dismissModals method to ContentSuggestions This CL implements the dismissModals method needed by the NewTabPagePanelProtocol, and merges the existing ones with it. BUG= 700375 Change-Id: I95ff37f649fb6a1e6ab29d3f3ed917d74883c80d Reviewed-on: https://chromium-review.googlesource.com/558873 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#483981} [modify] https://crrev.com/a90919df755b28d06305e1ecad9032322b054624/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/a90919df755b28d06305e1ecad9032322b054624/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/a90919df755b28d06305e1ecad9032322b054624/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/a90919df755b28d06305e1ecad9032322b054624/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/202930499e5efc7bddb88f4a382a1b6be1d61d02 commit 202930499e5efc7bddb88f4a382a1b6be1d61d02 Author: gambard <gambard@chromium.org> Date: Mon Jul 03 11:15:27 2017 Move tiles up/down when (un)focusing the omnibox This CL rewrites the way the HeaderController and the CollectionController are communicating with each others. The ContentSuggestionsHeaderCollectionCommandHandler is handling the interactions by conforming to the two commands protocols. It handles the move of the tiles and the updates of the fake omnibox. BUG= 700375 Change-Id: Id465531d7c09b3713c184307a247e0db897e5bcf Reviewed-on: https://chromium-review.googlesource.com/552148 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#483987} [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/content_suggestions/content_suggestions_header_controller.mm [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/content_suggestions/content_suggestions_header_controller_delegate.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_controlling.h [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_synchronizing.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [delete] https://crrev.com/45a1ceb8309b6076aea7d2885b7a62f8d3c549c9/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_commands.h [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.h [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizing.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [add] https://crrev.com/202930499e5efc7bddb88f4a382a1b6be1d61d02/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_audience.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c01b31617bbb14f59a8cd1f6474efa418bdca6ce commit c01b31617bbb14f59a8cd1f6474efa418bdca6ce Author: gambard <gambard@chromium.org> Date: Wed Jul 05 12:42:23 2017 Calculate header height for all form factors The header displayed in ContentSuggestions has a height depending of multiple parameters, including the device type, if a logo is presented... This CL uses the correct height for the header. BUG= 700375 Change-Id: I9a39a2129ebd1c5f6920ecec7f8a1e577a5cfe07 Reviewed-on: https://chromium-review.googlesource.com/558287 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#484252} [modify] https://crrev.com/c01b31617bbb14f59a8cd1f6474efa418bdca6ce/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/c01b31617bbb14f59a8cd1f6474efa418bdca6ce/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [modify] https://crrev.com/c01b31617bbb14f59a8cd1f6474efa418bdca6ce/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/c01b31617bbb14f59a8cd1f6474efa418bdca6ce/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15bfa36564d0728a5546d84fdb89cdbe3aa49e76 commit 15bfa36564d0728a5546d84fdb89cdbe3aa49e76 Author: gambard <gambard@chromium.org> Date: Thu Jul 06 09:28:35 2017 HeaderController is now a ViewController The ContentSuggestionsHeaderController is ViewController, allowing it to receive the notifications when the application size changes. BUG= 700375 Change-Id: I4b30851d46b89d31e5db23947f4de79cb73b0c8e Reviewed-on: https://chromium-review.googlesource.com/558248 Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#484515} [modify] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [modify] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [rename] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [rename] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [rename] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller_delegate.h [modify] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/15bfa36564d0728a5546d84fdb89cdbe3aa49e76/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd7b9bbdf176b5be8a74b1d55ae6048f340acb3 commit 1dd7b9bbdf176b5be8a74b1d55ae6048f340acb3 Author: gambard <gambard@chromium.org> Date: Thu Jul 06 13:28:58 2017 Update header height when logo display changes When the display of the logo changes (i.e. hidden or displayed), the header height and disposition changes. BUG= 700375 Change-Id: Icc8e9bec1a4a95826961d437265fc77afdf698b9 Reviewed-on: https://chromium-review.googlesource.com/558289 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#484567} [modify] https://crrev.com/1dd7b9bbdf176b5be8a74b1d55ae6048f340acb3/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/1dd7b9bbdf176b5be8a74b1d55ae6048f340acb3/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_synchronizing.h [modify] https://crrev.com/1dd7b9bbdf176b5be8a74b1d55ae6048f340acb3/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d36901d9b3367bcfe8f1dcc23b58f931df8b9ccc commit d36901d9b3367bcfe8f1dcc23b58f931df8b9ccc Author: gambard <gambard@chromium.org> Date: Mon Jul 10 08:30:31 2017 Fix animation on ContentSuggestions rotations When there is an animation on the NTP screen with ContentSuggestions, the appearing and disappearing icons are shown with an alpha of 1 during the whole animation. This CL fixes this by reloading the data during the rotation. Before: https://drive.google.com/open?id=0B21N-0pPGAuJMHVhWDRvdU55ODg After: https://drive.google.com/open?id=0B21N-0pPGAuJYm13cW5IVDRiUjQ BUG= 700375 Change-Id: Ie2c928ff1d012439cf329948713f2ff46887b7d2 Reviewed-on: https://chromium-review.googlesource.com/561776 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485199} [modify] https://crrev.com/d36901d9b3367bcfe8f1dcc23b58f931df8b9ccc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/d36901d9b3367bcfe8f1dcc23b58f931df8b9ccc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/d36901d9b3367bcfe8f1dcc23b58f931df8b9ccc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e101fdb2fbae25b04b7cb190ee5a5c882d65503 commit 0e101fdb2fbae25b04b7cb190ee5a5c882d65503 Author: gambard <gambard@chromium.org> Date: Wed Jul 26 09:41:13 2017 Pull-to-refresh reloads the suggestions When the pull-to-refresh overscroll action is used, the suggestions should be reloaded. If the suggestions are stale, the gesture will update the content. Bug: 740932 , 700375 Change-Id: I4c811c2d57d2b8ba78c3f1cad33e9466eda4a135 Reviewed-on: https://chromium-review.googlesource.com/585010 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#489581} [modify] https://crrev.com/0e101fdb2fbae25b04b7cb190ee5a5c882d65503/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
Comment 1 by gambard@chromium.org
, May 3 2017