Support both sequences and single RequestInfos in the fetch() method |
|||
Issue description
Background Fetch defines the following method:
Promise<BackgroundFetchRegistration> fetch(
DOMString tag,
(RequestInfo or sequence<RequestInfo>) requests,
optional BackgroundFetchOptions options);
The `requests` argument is a typedef, but so is `RequestInfo`. Our bindings generator does not support nested typedefs. (See Issue 700225 .)
For now I'll proceed with only supporting a sequence of RequestInfos, but we'll probably want to address this before shipping.
,
Mar 14 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/293b1855e6df88132db0ff0f5dd55ff835f8d7c0 commit 293b1855e6df88132db0ff0f5dd55ff835f8d7c0 Author: peter <peter@chromium.org> Date: Thu Mar 16 15:53:00 2017 Support the full `request` attribute types for the BGFetchManager.fetch() Raphael kindly improved the bindings generator to support nested union types, so we can now properly support this! BUG= 700370 Review-Url: https://codereview.chromium.org/2758493003 Cr-Commit-Position: refs/heads/master@{#457446} [modify] https://crrev.com/293b1855e6df88132db0ff0f5dd55ff835f8d7c0/third_party/WebKit/Source/bindings/modules/v8/generated.gni [modify] https://crrev.com/293b1855e6df88132db0ff0f5dd55ff835f8d7c0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp [modify] https://crrev.com/293b1855e6df88132db0ff0f5dd55ff835f8d7c0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h [modify] https://crrev.com/293b1855e6df88132db0ff0f5dd55ff835f8d7c0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl
,
Mar 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by raphael....@intel.com
, Mar 14 2017