New issue
Advanced search Search tips

Issue 700366 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 699242



Sign in to add a comment

Add support for passing device flags to instrumentation tests directly on the command line

Project Member Reported by jbudorick@chromium.org, Mar 10 2017 
test_runner.py supports device flags for instrumentation tests via a file w/ both the --device-flags and the --device-flags-file (the former is deprecated but has not yet been eradicated). This doesn't work well for the //testing/buildbot/ json files, though -- it'd be much easier if the flags could be specified w/o dealing with a file, e.g.

  test_runner.py instrumentation ... --device-flags=--enable-browser-side-navigation
                                 (or --test-arguments=--enable-browser-side-navigation)

Comment 1 by jbudorick@chromium.org, Mar 10 2017

Blocking: 699242

Comment 2 by jbudorick@chromium.org, Mar 10 2017

Status: Started (was: Assigned)
on review: https://codereview.chromium.org/2743033002/

Comment 3 by jbudorick@chromium.org, Mar 10 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/0e697705ae378e51eb34e166c2c702cb1954c320

commit 0e697705ae378e51eb34e166c2c702cb1954c320
Author: John Budorick <jbudorick@google.com>
Date: Fri Mar 10 18:41:14 2017

Comment 5 by jbudorick@chromium.org, Mar 13 2017 

revised implementation on review: https://codereview.chromium.org/2752493002/
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d30806cf9bcb492d60dab0b3987aba72ff59f87

commit 7d30806cf9bcb492d60dab0b3987aba72ff59f87
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Mar 16 19:18:52 2017

[android] Add support for passing command-line flags directly.

Previously, command-line flags to be passed to the test had to be
passed via:
 - (gtests) --test-arguments <string>
 - (instrumentation tests) --device-flags{,-file} <file>

This CL changes it s.t. any flags not recognized by the test runner
are passed down to the binary. It also removes --device-flags and
deprecates --test-arguments.

BUG= 700366 

Review-Url: https://codereview.chromium.org/2752493002
Cr-Commit-Position: refs/heads/master@{#457513}

[modify] https://crrev.com/7d30806cf9bcb492d60dab0b3987aba72ff59f87/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/7d30806cf9bcb492d60dab0b3987aba72ff59f87/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/7d30806cf9bcb492d60dab0b3987aba72ff59f87/build/android/pylib/instrumentation/instrumentation_test_instance_test.py
[modify] https://crrev.com/7d30806cf9bcb492d60dab0b3987aba72ff59f87/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/7d30806cf9bcb492d60dab0b3987aba72ff59f87/build/android/test_runner.py
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d515b67d7eade38f063aa2814fc735272c4b2f

commit e0d515b67d7eade38f063aa2814fc735272c4b2f
Author: jbudorick <jbudorick@chromium.org>
Date: Sat Mar 18 02:47:51 2017

[Android] Update existing uses of now-deprecated --test-arguments.

BUG= 700366 

Review-Url: https://codereview.chromium.org/2756603003
Cr-Commit-Position: refs/heads/master@{#457938}

[modify] https://crrev.com/e0d515b67d7eade38f063aa2814fc735272c4b2f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e0d515b67d7eade38f063aa2814fc735272c4b2f/testing/buildbot/filters/README.md

Comment 9 by jbudorick@chromium.org, May 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment