The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865a357dda206267aafd20d23382b452cec8c084

commit 865a357dda206267aafd20d23382b452cec8c084
Author: miguelg <miguelg@chromium.org>
Date: Fri Mar 10 11:42:01 2017

Do not delete notification ids unknown by the display service

This is a temporary set of reverts so they can go into M58.

Revert "clean up LayoutTestNotificationManager overrides"
This reverts commit 0e9764ee9211235cb379f45df8bf983af2b0b0aa.
Revert "Test the platform notification context synchronize operation"
This reverts commit f3f824cd5032eac3c694bd9b7a5c05a2e45ebc5c.
Revert "Fix a couple of notification TODOs"
This reverts commit e50bfa204461eba626ab5891799669f9bf8231be.

BUG= 571056 , 700343 

Review-Url: https://codereview.chromium.org/2739943006
Cr-Commit-Position: refs/heads/master@{#456041}

[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/865a357dda206267aafd20d23382b452cec8c084/content/test/BUILD.gn

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Some context, the only relevant file touching production code is https://codereview.chromium.org/2739943006/patch/20001/30002 everything else were just some refactors done in order to test this properly.

The code it affects will not be shipping in production in M58 but there are many  people with flag manually on and without this change they could face a situation where alerts become unresponsive.

Thank you  miguelg@. How is this change looking in Canary?

Friendly ping - Can you please comment how this change looks in Canary? We are pushing to Beta on Thursday will need to merge before 5PM Tomorrow. 

Oh sorry about missing this. The change is working great in canary.

repro steps:
  https://tests.peter.sh/notification-generator/
  Tick on "Req. interaction" then click "Display the notification"
Without clicking the resulting alert click "Get Displayed notifications"

Before the patch the showing alert would not be clickable any more. Now it is.

Thanks! please go ahead and merge for M58. Branch: 3029

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3c1d9d6170108539e5ba8662692e0478366daac

commit b3c1d9d6170108539e5ba8662692e0478366daac
Author: Miguel Garcia <miguelg@chromium.org>
Date: Wed Mar 15 21:51:42 2017

Do not delete notification ids unknown by the display service

This is a temporary set of reverts so they can go into M58.

Revert "clean up LayoutTestNotificationManager overrides"
This reverts commit 0e9764ee9211235cb379f45df8bf983af2b0b0aa.
Revert "Test the platform notification context synchronize operation"
This reverts commit f3f824cd5032eac3c694bd9b7a5c05a2e45ebc5c.
Revert "Fix a couple of notification TODOs"
This reverts commit e50bfa204461eba626ab5891799669f9bf8231be.

BUG= 571056 , 700343 

Review-Url: https://codereview.chromium.org/2739943006
Cr-Commit-Position: refs/heads/master@{#456041}
(cherry picked from commit 865a357dda206267aafd20d23382b452cec8c084)

Review-Url: https://codereview.chromium.org/2748133006 .
Cr-Commit-Position: refs/branch-heads/3029@{#218}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/b3c1d9d6170108539e5ba8662692e0478366daac/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc61bbbad13394f8286af84eb49d60d3f4b1882

commit abc61bbbad13394f8286af84eb49d60d3f4b1882
Author: miguelg <miguelg@chromium.org>
Date: Thu May 11 12:16:07 2017

RE-add the ability to delete notification ids unknown by the display service.

This is a manual revert of 865a357dda206267aafd20d23382b452cec8c084

BUG= 700343 

Review-Url: https://codereview.chromium.org/2868793003
Cr-Commit-Position: refs/heads/master@{#470930}

[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/abc61bbbad13394f8286af84eb49d60d3f4b1882/content/test/BUILD.gn