New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700327 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring is seen for 'For quick access, place your bookmarks here on the bookmarks bar' and it is editable

Reported by jshan...@etouch.net, Mar 10 2017

Issue description

Chrome version: 59.0.3037.0 (Official Build) 9018c99b7f73801b958f5079f68a8fda1519f480-refs/heads/master@{#455955}-32/64 bit
OS:Mac OS X(10.11.6, 10.12.1)

Steps:
1. Launch Chrome and open NTP
2. Press tab and observe

Actual: Unnecessary focus ring is seen for 'For quick access, place your bookmarks here on the bookmarks bar' and it is editable 

Expected: Focus ring should not be seen for 'For quick access, place your bookmarks here on the bookmarks bar' and it should not be editable 

This is a regression issue, broken in 'M-59', will soon update the other info:

Good Build: 59.0.3035.0
Bad Build: 59.0.3036.0
 

 
Actual_video.mov
5.0 MB Download
Expected_video.mov
856 KB Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)

Comment 2 by shrike@chromium.org, Mar 10 2017

Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Taking a guess it might be related to https://codereview.chromium.org/2729603008/.

Comment 3 by lgrey@chromium.org, Mar 10 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14eb3c22737921e06fca8768ec75398e1c86f451

commit 14eb3c22737921e06fca8768ec75398e1c86f451
Author: lgrey <lgrey@chromium.org>
Date: Fri Mar 10 21:38:55 2017

[Mac] Restore bookmark bar no items text field to uneditable

BUG= 700327 

Review-Url: https://codereview.chromium.org/2743803003
Cr-Commit-Position: refs/heads/master@{#456171}

[modify] https://crrev.com/14eb3c22737921e06fca8768ec75398e1c86f451/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

Comment 5 by shrike@chromium.org, Mar 10 2017

Labels: -Needs-Bisect

Comment 6 by jshan...@etouch.net, Mar 14 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3040.0
Above issue is fixed latest canary version 59.0.3040.0 on Mac OS X(10.11.6, 10.12.1).
Please refer the attached screencast.
Fixed_video.mov
1.9 MB Download

Comment 7 by lgrey@chromium.org, Mar 14 2017

Status: Fixed (was: Started)

Sign in to add a comment