New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700305 link

Starred by 2 users
Status: Fixed
Owner:
enne@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In Print preview, pages are seen blank on scroll down for chrome://credits.

Reported by lpa...@etouch.net, Mar 10 2017 
Chrome Version: 59.0.3037.0 (Official Build) 9018c99b7f73801b958f5079f68a8fda1519f480-refs/heads/master@{#455955} (32/64-bit)
OS: Windows (7,8,10), Linux (14.04 LTS), Mac (10.11.6, 10.12.1)

What steps will reproduce the problem?
1) Launch chrome, go to 'chrome://credits' and give 'Print' command.
2) In Preview section, scroll down and observe.

Pages are seen blank in Preview section.

Pages should not be seen blank in Preview section.

This is a Regression issue broken in M-59, will soon update other info
Manual bisect:
Good build: 59.0.3036.0 
Bad build: 59.0.3037.0
credits_actual.mp4
981 KB View Download
credits_expected.mp4
1.4 MB View Download

Comment 1 by rbasuvula@chromium.org, Mar 10 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Beta
Owner: enne@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3036.0 (Revision: 455621).
Bad build:59.0.3037.0  (Revision: 455955).

You are probably looking for a change made after 455839 (known good), but no later than 455840 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/3e8277dbaf900a53ab0ec812a030ac4a95f7323a..d2501577f2df0764eda66614ddf429e230062562

From the CL above, assigning the issue to the concern owner

@enne: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2690583002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3037.0
Adding Release Block-Beta for this issue.Please remove if not the case.

Comment 2 by manoranj...@chromium.org, Mar 11 2017 

enne@, would be great if you can land a fix/revert ASAP.

Thank you!

Comment 3 by enne@chromium.org, Mar 11 2017 

Patch is in the commit queue: https://codereview.chromium.org/2743143002
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c66c935afbaa133537402a41bd619f79920d3ed

commit 3c66c935afbaa133537402a41bd619f79920d3ed
Author: enne <enne@chromium.org>
Date: Mon Mar 13 20:28:50 2017

Fix incorrect print preview clipping

After https://codereview.chromium.org/2690583002 landed, it changed
a number of SkPicture::playback calls to SkCanvas::drawPicture calls
which also include a clip rect.  (See link for reasons why.)

WebLocalFrameImpl set an unscaled and untranslated SkPicture rect size,
which caused pages that were not at the origin to be clipped.  This
patch adjusts the rect on the recorder so that pages are not
accidentally culled.

BUG= 700305 

Review-Url: https://codereview.chromium.org/2743143002
Cr-Commit-Position: refs/heads/master@{#456465}

[modify] https://crrev.com/3c66c935afbaa133537402a41bd619f79920d3ed/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Comment 5 by sureshkumari@chromium.org, Mar 15 2017

Labels: TE-Verified-59.0.3042.0 TE-Verified-M59
Tested the issue on Windows-7,Mac-10.12.3 and Linux Ubuntu 14.04 using chrome version #59.0.3042.0 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
Win-700305.mp4
3.4 MB View Download

Comment 6 by manoranj...@chromium.org, Mar 17 2017 

enne@, please mark it as 'Fixed' if there is no fix is pending.

Comment 7 by enne@chromium.org, Mar 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment