New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700281 link

Starred by 1 user
Status: Fixed
Owner:
█ alokp@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
qyears...@chromium.org
█ yzshen@chromium.org
jeffcarp@chromium.org
█ mcgreevy@chromium.org
dpranke@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

mojo/binding.html is timing out when layout tests are run on swarming

Project Member Reported by tansell@chromium.org, Mar 10 2017 
Same failure on multiple builds;

 * https://chromium-swarm.appspot.com/task?id=34cfac5e3f9f6e10&refresh=10&show_raw=1
 * https://chromium-swarm.appspot.com/task?id=34cf8926aaa3fd10&refresh=10&show_raw=1
 * https://chromium-swarm.appspot.com/task?id=34cf649716cc9110&refresh=10&show_raw=1
 * https://chromium-swarm.appspot.com/task?id=34cf3ff19763db10&refresh=10&show_raw=1

(And more from https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Linux%20-%20RandomOrder/?limit=200)

They are failing with;
------------------

Regressions: Unexpected timeouts (1)
  mojo/binding.html [ Timeout ]

------------------

From looking at the stderr for that test, it might be because there is an error in the build rule which means files might not being included in the isolate input?

-----------------------
[1130:1212:0309/215647.588612:23458931828:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
[1130:1212:0309/215647.588960:23458932173:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry
[1:1:0309/215647.594301:23458937645:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry"
[1:1:0309/215647.594536:23458937798:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry"
[1:1:0309/215647.594651:23458937912:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "mojo/public/interfaces/bindings/tests/math_calculator.mojom"
-----------------------

Comment 1 by tansell@chromium.org, Mar 10 2017 

Hi Sam,

As the only person I know who works on Mojo, I have a couple of questions about what is going on here. Could you take a look at them or forward it to someone who might know the answer?

 * Could these ERROR/WARNINGs be causing this layout test to be timing out? 
 * Should these files be available when running content shell? If so, any idea why they are not ending up in the data_deps?
 * Any idea why this just started timing out?

Thanks!
Thanks!

Comment 2 by sa...@chromium.org, Mar 10 2017

Cc: alokp@chromium.org yzshen@chromium.org
Status: Available (was: Untriaged)
The JS bindings file generated from mojo/public/interfaces/bindings/tests/math_calculator.mojom is probably missing from data_deps. The test will wait until all resources load. It looks like this test was added today: https://chromium.googlesource.com/chromium/src/+/5bf97f6bf369fc1d5b5bb77585f5c13dc218c216.

I expect fixing this should just require adding some deps or data_deps to the layout tests target. I'll take a look Monday if no one else gets to it first.

Comment 3 by alokp@chromium.org, Mar 10 2017

Cc: -alokp@chromium.org
Owner: alokp@chromium.org
Status: Started (was: Available)

Comment 4 by alokp@chromium.org, Mar 10 2017 

Patch in review: https://codereview.chromium.org/2742793003/
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b900d1d15eee1867ffdc2a3d32cc69b439ea21

commit 51b900d1d15eee1867ffdc2a3d32cc69b439ea21
Author: alokp <alokp@chromium.org>
Date: Fri Mar 10 18:55:39 2017

Adds blink_tests -> mojo test interfaces runtime dependency.

This is so that mojo/binding.html can find the generated bindings for
math_calculator.mojom. This layout test was added in r455925, but failed
to add this data dependency.

BUG= 700281 
TEST=gn desc blink_tests runtime_deps

Review-Url: https://codereview.chromium.org/2742793003
Cr-Commit-Position: refs/heads/master@{#456119}

[modify] https://crrev.com/51b900d1d15eee1867ffdc2a3d32cc69b439ea21/BUILD.gn

Comment 6 by alokp@chromium.org, Mar 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment