Range.surroundContents() for detached CharacterData is not interoperable |
||
Issue descriptionChrome Version: 59 Canary OS: All but iOS What steps will reproduce the problem? (1) open http://w3c-test.org/dom/ranges/Range-surroundContents.html What is the expected result? No FAILs What happens instead? There are multiple FAIL about detached Text/CharacterData/ProcessingInstruction. Please use labels and text to provide additional information. Our implementation has un-specified precondition check for detached CharacterData. It's unnecessary. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb61c80a7256f706df0fd62de61afd5c62ccb69 commit cfb61c80a7256f706df0fd62de61afd5c62ccb69 Author: tkent <tkent@chromium.org> Date: Fri Mar 10 10:49:09 2017 Range: surroundContents() should not check detached CharacterData node beforehand. Our implementation had unnecessary precondition check for detached CharacterData, and it's not defined by the DOM standard. This CL removes it. * fast/dom/Range/31684.html: Removed This CL changes the exception message in this test. We remove this because It's well tested in WPT. BUG= 700275 Review-Url: https://codereview.chromium.org/2740293002 Cr-Commit-Position: refs/heads/master@{#456037} [delete] https://crrev.com/22a37f49e50636144bbae9d5c391d9efbf9c90a6/third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-surroundContents-expected.txt [delete] https://crrev.com/22a37f49e50636144bbae9d5c391d9efbf9c90a6/third_party/WebKit/LayoutTests/fast/dom/Range/31684-expected.txt [delete] https://crrev.com/22a37f49e50636144bbae9d5c391d9efbf9c90a6/third_party/WebKit/LayoutTests/fast/dom/Range/31684.html [modify] https://crrev.com/cfb61c80a7256f706df0fd62de61afd5c62ccb69/third_party/WebKit/Source/core/dom/Range.cpp
,
Mar 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by tkent@chromium.org
, Mar 10 2017Status: Started (was: Available)