Cleanup logic handling Drive Orientation in ImageLoader |
||||||||||
Issue descriptionIt looks like Drive Orientation is not actually used anymore as a means of expressing an image orientation in the Files app and the Gallery. https://cs.chromium.org/chromium/src/ui/file_manager/image_loader/image_loader.js?type=cs&q=ImageLoader+DriveOrientation&l=73 Remove such logic in ImageLoader after making sure that it's not used.
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Apr 12 2018
,
Sep 17
,
Oct 31
,
Nov 18
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc4016edd692863ac422047555b2c8a6929eeaa commit 8fc4016edd692863ac422047555b2c8a6929eeaa Author: Stuart Langley <slangley@google.com> Date: Mon Nov 19 04:34:33 2018 Remove ImageOrientation.fromDriveOrientation as it's no longer used. I did a bit of a code search and could not find this being used anymore, so removing it as per the suggested bug. - Added an assert just in case it was being used and my code search skills were not good enough, so we can roll it back. - Closure compile the unit tests while I am at it. Bug: 700272 Change-Id: I5523bbff983fbad3be886319d17278e4673915e3 Reviewed-on: https://chromium-review.googlesource.com/c/1341433 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609179} [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/BUILD.gn [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js [delete] https://crrev.com/08b514350963b82a26a58a913934b592501c64c2/ui/file_manager/file_manager/foreground/js/metadata/image_orientation_unittest.html [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/image_loader/image_loader.js [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/image_loader/image_loader_unittest.js [modify] https://crrev.com/8fc4016edd692863ac422047555b2c8a6929eeaa/ui/file_manager/image_loader/load_image_request.js
,
Nov 19
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by slangley@chromium.org
, Feb 19 2018Status: Untriaged (was: Unconfirmed)