The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab369a14712059bfbdca40ccff278d6b7c8ec7dc

commit ab369a14712059bfbdca40ccff278d6b7c8ec7dc
Author: guidou <guidou@chromium.org>
Date: Fri Mar 10 12:20:09 2017

Disable flaky BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing on Mac.

BUG= 700271 
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2738403003
Cr-Commit-Position: refs/heads/master@{#456044}

[modify] https://crrev.com/ab369a14712059bfbdca40ccff278d6b7c8ec7dc/chrome/browser/lifetime/browser_close_manager_browsertest.cc

sky@: can you help triage this bug? You reviewed the last change to this test.

I'm the author of the test.
Here in Yandex we haven't seen problems with the test yet.
And the stacktrace looks a bit strange (from your logs).
Maybe it depends on some gn args.
Could you post exact gn args here?
I'll try to investigate.

The stacktrace from logs: "
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x00000001078311dc base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x00000001082293da content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 202
2   libsystem_platform.dylib            0x00007fff906bb5aa _sigtramp + 26
3   ???                                 0x0000000000000000 0x0 + 0
4   browser_tests                       0x00000001094e5180 l10n_util::GetStringUTF16(int) + 32
5   browser_tests                       0x00000001094ea899 l10n_util::GetNSStringWithFixup(int) + 25
6   browser_tests                       0x000000010b629800 -[ReloadButton updateTag:] + 128
7   browser_tests                       0x000000010b629994 -[ReloadButton setIsLoading:force:] + 132
8   browser_tests                       0x000000010b629685 -[ReloadButton viewWillMoveToWindow:] + 37
9   AppKit                              0x00007fff8d22670a -[NSView _setWindow:] + 205
10  AppKit                              0x00007fff8d238de5 -[NSControl _setWindow:] + 154
11  AppKit                              0x00007fff8d238c9e -[NSButton _setWindow:] + 48
12  CoreFoundation                      0x00007fff94b482f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
13  CoreFoundation                      0x00007fff94b47a9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
14  AppKit                              0x00007fff8d96ac72 __21-[NSView _setWindow:]_block_invoke712 + 231
15  AppKit                              0x00007fff8d22715f -[NSView _setWindow:] + 2850
16  CoreFoundation                      0x00007fff94b482f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
17  CoreFoundation                      0x00007fff94b47a9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
18  AppKit                              0x00007fff8d96ac72 __21-[NSView _setWindow:]_block_invoke712 + 231
19  AppKit                              0x00007fff8d22715f -[NSView _setWindow:] + 2850
20  CoreFoundation                      0x00007fff94b482f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
21  CoreFoundation                      0x00007fff94b47a9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
22  AppKit                              0x00007fff8d96ac72 __21-[NSView _setWindow:]_block_invoke712 + 231
23  AppKit                              0x00007fff8d22715f -[NSView _setWindow:] + 2850
24  CoreFoundation                      0x00007fff94b482f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
25  CoreFoundation                      0x00007fff94b47a9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
26  AppKit                              0x00007fff8d96ac72 __21-[NSView _setWindow:]_block_invoke712 + 231
27  AppKit                              0x00007fff8d22715f -[NSView _setWindow:] + 2850
28  AppKit                              0x00007fff8d2300ed -[NSThemeFrame _setWindow:] + 111
29  AppKit                              0x00007fff8d47ded9 -[NSWindow dealloc] + 1163
30  browser_tests                       0x000000010b5a93d5 -[FramedBrowserWindow dealloc] + 85
31  AppKit                              0x00007fff8d22f5ea -[NSWindow release] + 193
32  AppKit                              0x00007fff8d4c106b -[_NSWindowTransformAnimation dealloc] + 115
33  libsystem_blocks.dylib              0x00007fff8c4386f0 _Block_release + 196
34  CoreFoundation                      0x00007fff94b36aed __CFRunLoopDoBlocks + 349
35  CoreFoundation                      0x00007fff94b363de __CFRunLoopRun + 814
36  CoreFoundation                      0x00007fff94b35e75 CFRunLoopRunSpecific + 309
37  browser_tests                       0x00000001078746df base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) + 79
38  browser_tests                       0x0000000107873fc7 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 119
39  browser_tests                       0x000000010786e801 base::MessageLoop::RunHandler() + 369
40  browser_tests                       0x00000001078a5637 base::RunLoop::Run() + 151
41  browser_tests                       0x000000010878d878 net::test_server::EmbeddedTestServer::PostTaskToIOThreadAndWait(base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 392
42  browser_tests                       0x000000010878c338 net::test_server::EmbeddedTestServer::ShutdownAndWaitUntilComplete() + 184
43  browser_tests                       0x000000010878c045 net::test_server::EmbeddedTestServer::~EmbeddedTestServer() + 117
44  browser_tests                       0x0000000108228455 content::BrowserTestBase::~BrowserTestBase() + 165
45  browser_tests                       0x0000000104da0ade BrowserCloseManagerBrowserTest_AddBeforeUnloadDuringClosing_Test::~BrowserCloseManagerBrowserTest_AddBeforeUnloadDuringClosing_Test() + 94
46  browser_tests                       0x0000000108cc3838 testing::TestInfo::Run() + 392
47  browser_tests                       0x0000000108cc3e27 testing::TestCase::Run() + 263
48  browser_tests                       0x0000000108ccae87 testing::internal::UnitTestImpl::RunAllTests() + 871
49  browser_tests                       0x0000000108ccaaf3 testing::UnitTest::Run() + 163
50  browser_tests                       0x0000000107978193 base::TestSuite::Run() + 163
51  browser_tests                       0x00000001078169cf ChromeTestSuiteRunner::RunTestSuite(int, char**) + 31
52  browser_tests                       0x0000000108277af2 content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 386
53  browser_tests                       0x00000001078167ca main + 90
54  libdyld.dylib                       0x00007fff899b55fd start + 1

mkolom, probably obvious, but I'll mention anyway. The failure is on a mac. I'm not sure if you can't see the try runs, which give the gn args used. Specifically the generate_build_files step https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F404330%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files__with_patch_%2F0%2Fstdout is one example. Here's the args: 
dcheck_always_on = true
ffmpeg_branding = "Chrome"
goma_dir = "/b/c/goma_client"
is_component_build = false
is_debug = false
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
use_goma = true

I can't imagine the ffmpeg_branding one matters.

The stack doesn't look at all related to your patch. My guess is it's something else and your test just happened to trigger it.

I've tried several times using these gn args and --gtest_repeat=1000: test works fine.
I tried to stress my machine/OS and vice versa tried to keep it "singletasked" - the result is the same.
So I don't know how to help with this problem.

Master at ad5d52437c9f5cd1e412e0a6a845ad01c592cf88 (Mar 10), macbook pro mid 2014, macos sierra 10.12.3

This might be due to a change that I made.

I'm tagging this bug in a fix I'm working on. Once that fix lands, please re-test to see if the flakiness is gone.

(Follow along in  bug 705306 .)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64b8b65b733a3ac8bd0b5f707431f6d1fae20948

commit 64b8b65b733a3ac8bd0b5f707431f6d1fae20948
Author: avi <avi@chromium.org>
Date: Wed Mar 29 18:50:34 2017

Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were attempting to disable the beforeunload timeout, but the switch provided no longer worked.

BUG= 705306 ,  418266 ,  700271 ,  700641 
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2777013004
Cr-Commit-Position: refs/heads/master@{#460472}

[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/public/browser/render_frame_host.h
[modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/public/browser/render_widget_host.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d2fdd58a870311125af22464402ffd7e74db50

commit 48d2fdd58a870311125af22464402ffd7e74db50
Author: avi <avi@chromium.org>
Date: Thu Mar 30 03:50:17 2017

Re-enable BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing.

It started flaking about the time that the beforeunload timer was split off, a bug that was just fixed in 64b8b65b733a3ac8bd0b5f707431f6d1fae20948.

BUG= 700271 
TEST=stays green, doesn't flake

Review-Url: https://codereview.chromium.org/2786833002
Cr-Commit-Position: refs/heads/master@{#460651}

[modify] https://crrev.com/48d2fdd58a870311125af22464402ffd7e74db50/chrome/browser/lifetime/browser_close_manager_browsertest.cc