New issue
Advanced search Search tips

Issue 700263 link

Starred by 1 user
Status: Fixed
Owner:
hinoka@chromium.org
Closed: Apr 2017
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

No pagination controls on build list page (IE previous 100 builds)

Project Member Reported by tansell@chromium.org, Mar 10 2017 
What steps will reproduce the problem?
(1) Go to https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Linux%20-%20RandomOrder/
(2) Want to see the previous 100 builds
(3) Have to just keep increasing the number of build limits.

What is the expected result?

Have '<prev' / 'next>' links which let you skip back and forward through the builds list.

Comment 1 by tansell@chromium.org, Mar 10 2017

Description: Show this description

Comment 2 by no...@chromium.org, Mar 10 2017

Status: Available (was: Untriaged)

Comment 3 by no...@chromium.org, Mar 20 2017

Components: Infra>Platform>Milo>Buildbot

Comment 4 by no...@chromium.org, Mar 20 2017

Components: -Infra>Platform>Milo
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/9fb9880d65325cef1fd8ff4099a1de27b4bf684e

commit 9fb9880d65325cef1fd8ff4099a1de27b4bf684e
Author: hinoka <hinoka@google.com>
Date: Thu Apr 20 22:17:27 2017

Milo buildbot builder page: Add pagnation with cursors.

In the UI, backward pages are implemented via memcache, just like luci scheduler
In the API, backward pages are not supported

Note that for the most part we operate around pointers to cursors, to store the state that "the cursor does not exist", ie the end of the query has been reached.

BUG= 679931 , 700263 

Review-Url: https://codereview.chromium.org/2810113002

[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/buildbot.pb.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/buildbot.proto
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/pb.discovery.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/resp/builder.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/builder.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/console.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/datastore.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/grpc.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/html.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/common/funcs.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/common/middleware.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/expectations/buildbot.builder-Basic_Test_no_builds.html
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/templates/pages/builder.html

Comment 6 by hinoka@chromium.org, Apr 22 2017

Owner: hinoka@chromium.org
Status: Fixed (was: Available)
This is live
►

Sign in to add a comment