New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700253 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Settings button on a ARC notification doesn't work in MNC.

Project Member Reported by yhanada@chromium.org, Mar 10 2017

Issue description

Settings button is added on a ARC notification, but it doesn't work on
 MNC.

yoshiki@: What should we do on MNC?

 
Owner: yhanada@chromium.org
Status: Assigned (was: Untriaged)
As chatted with yoshiki@ offline, I'll hide the settings button on MNC.

Comment 2 by uekawa@google.com, Mar 15 2017

b/36220293
Labels: Merge-Request-58
Status: Started (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 21 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 21 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c40a2361759cf05a715d76cb5204ddbd55dcfb

commit 44c40a2361759cf05a715d76cb5204ddbd55dcfb
Author: yhanada <yhanada@chromium.org>
Date: Tue Mar 21 05:38:39 2017

Hide the settings button on a notification in MNC.

BUG= 700253 
TEST=Check that the settings button shows in NYC and it hides in MNC.

Review-Url: https://codereview.chromium.org/2747383002
Cr-Commit-Position: refs/heads/master@{#457688}
(cherry picked from commit 24d294391f1a0fce66fa1802d09f9e4a89a94841)

Review-Url: https://codereview.chromium.org/2763913003 .
Cr-Commit-Position: refs/branch-heads/3029@{#319}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_custom_notification_item.h
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_custom_notification_view.h
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_notification_item.cc
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_notification_item.h
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/44c40a2361759cf05a715d76cb5204ddbd55dcfb/ui/arc/notification/arc_notification_manager.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on chrome 58.0.3029.36/9334.20.0 cyan

Sign in to add a comment