This is for adding support for features that require invisible download jobs e.g. if the feature is batching multiple download requests and but only showing the aggregate status in the UI. Need to add database support for this.
Can this bug please link to the design doc?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd49a3edab3d755944e10202569fe90f12f32bbb commit fd49a3edab3d755944e10202569fe90f12f32bbb Author: shaktisahu <shaktisahu@chromium.org> Date: Thu Mar 30 18:35:10 2017 Downloads: Added transient flag to download item and download database This CL adds a visible flag to the download items and database. This boolean can be used in future by any feature that wants to have download items that should not be shown on the UI. BUG= 700240 Review-Url: https://codereview.chromium.org/2720613002 Cr-Commit-Position: refs/heads/master@{#460833} [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/android/download/download_manager_service.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/browsing_data/downloads_counter_browsertest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/download/download_history.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/download/download_history_unittest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/download/download_ui_controller_unittest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/download_database.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/download_database.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/download_row.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/download_row.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/history_backend_db_unittest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/browser/history_database.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/components/history/core/test/history_backend_db_base_test.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_browsertest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_item_factory.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_item_impl.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_item_impl.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_manager_impl.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/download_manager_impl_unittest.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/browser/download/mock_download_item_impl.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/browser/download_item.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/browser/download_manager.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/test/fake_download_item.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/test/fake_download_item.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/test/mock_download_item.h [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/test/mock_download_manager.cc [modify] https://crrev.com/fd49a3edab3d755944e10202569fe90f12f32bbb/content/public/test/mock_download_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6564f4e73457259075fd14acd488970b156c281 commit c6564f4e73457259075fd14acd488970b156c281 Author: shaktisahu <shaktisahu@chromium.org> Date: Fri Apr 07 23:15:28 2017 DownloadManager : Create transient downloads This CL enables callers to optionally set transient when starting a download. BUG= 700240 Review-Url: https://codereview.chromium.org/2791453003 Cr-Commit-Position: refs/heads/master@{#463040} [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/browser/download/download_create_info.cc [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/browser/download/download_create_info.h [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/browser/download/download_item_impl.cc [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/browser/download/download_request_core.cc [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/browser/download/download_request_core.h [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/public/browser/download_url_parameters.cc [modify] https://crrev.com/c6564f4e73457259075fd14acd488970b156c281/content/public/browser/download_url_parameters.h
Comment 1 by brettw@chromium.org
, Mar 20 2017