New issue
Advanced search Search tips

Issue 700236 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 887942
Owner:
Closed: Jan 21
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 620323

Blocking:
issue 826781



Sign in to add a comment

Remove proguard -keepnames for Parcelables

Project Member Reported by agrieve@chromium.org, Mar 10 2017

Issue description

We have the following rule in chromium_apk.flags:
-keepnames class * implements android.os.Parcelable

And within chromium_code.flags we have:
-keepnames class org.chromium.** implements android.os.Parcelable

Links:
https://cs.chromium.org/chromium/src/base/android/proguard/chromium_apk.flags?type=cs&q=file:flags+android.os.Parcelable&sq=package:chromium&l=19

https://cs.chromium.org/chromium/src/base/android/proguard/chromium_code.flags?type=cs&q=file:flags+android.os.Parcelable&sq=package:chromium&l=58

The first one is overly broad and can likely be removed.

The second one we can wait on investigating until after we enable renaming for org.chromium anyways.
 
Labels: -binary-size Performance-Size
Blocking: 826781
Owner: smaier@chromium.org
Status: Assigned (was: Available)

Comment 4 by smaier@google.com, Jan 21 (2 days ago)

Mergedinto: 887942
Status: Duplicate (was: Assigned)

Sign in to add a comment