New issue
Advanced search Search tips

Issue 700217 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We should get rid of SpellChecker::clearMisspellingsForMovingParagraphs()

Project Member Reported by yosin@chromium.org, Mar 10 2017

Issue description

This function removes markers for nodes will be removed. 
Node removal should remove remove markers.


 

Comment 1 by yosin@chromium.org, Mar 10 2017

Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Could you take look? ;-)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dede133389c377cc53eff4fd50d6a220318d882

commit 9dede133389c377cc53eff4fd50d6a220318d882
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Mar 30 03:52:30 2017

Remove useless SpellChecker::clearMisspellingsForMovingParagraphs()

The above mentioned functions removes markers from nodes that will be
removed, which is meaningless because node removal removes marker
eventually.

Hence, this patch removes this function.

BUG= 700217 
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2781213002
Cr-Commit-Position: refs/heads/master@{#460652}

[modify] https://crrev.com/9dede133389c377cc53eff4fd50d6a220318d882/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/9dede133389c377cc53eff4fd50d6a220318d882/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/9dede133389c377cc53eff4fd50d6a220318d882/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Status: Fixed (was: Assigned)

Sign in to add a comment