New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700200 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

repair jobs fail for devices in dev mode

Project Member Reported by drinkcat@chromium.org, Mar 9 2017

Issue description

Ever since this CL was committed, https://chromium-review.googlesource.com/446662 (issue 392289), devices in the lab must not be in dev mode, else the repair job will fail.

This is a problem for the 9 crouton devices we have in the lab (pool:crouton), as they are normal devices that we switched to dev mode for our test purpose.

What's the appropriate steps here? Should we switch them to a dev-signed firmware? Or is there any chance that test could be removed/made dependent on some label?
 
"is there any chance that test could be removed/made dependent on some label?", it sounds technically doable. 

But I don't know whether it's right to do it. Waiting for @richard's opinions.
It's preferable if the devices can be re-keyed with dev-signed
firmware.  If that's too labor intensive, or if there's some
reason they need to be in dev mode, we can add an exception based
on a label like the pool label.  That's already done for a few
other verifiers and repair actions, see here:
    https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/hosts/cros_firmware.py?l=91

#2: Thanks. I'd really prefer not to have to pick up the 9 devices, open them, and flash them with a new firmware... It's also more convenient for us not to have to do that when we replace devices.

Are we (crouton devs) the only ones with non-managed devices in the lab? If so, I guess we could match pool:crouton, if not, we could apply some other label to our machines and match that.
Matching pool:crouton should be fine.  You'll want to make
sure that the devices can't/won't accidentally get relabeled
for other testing by whoever is managing the chromeos1 lab.
I assume that that's already been done, though.

I note that the devices are already ineligible for the
managed pools, because they don't live in a lab in Stierlin Ct.

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5184c0cc86471f41ae8920af77a922483cb9c964

commit 5184c0cc86471f41ae8920af77a922483cb9c964
Author: Nicolas Boichat <drinkcat@google.com>
Date: Mon Mar 13 09:54:14 2017

autotest: Allow device in some pools to be in dev mode

This adds a new config option "pools_dev_mode_allowed" that
contains a comma-separate list of pools whose devices are
allowed to be in dev mode (e.g., running production firmware).

This is useful for self-managed devices in high touch lab, such
as the ones in pool:crouton.

BUG= chromium:700200 
TEST=Devices in pool:crouton can pass repair/verify stage.

Change-Id: Id9dbe90a84e32f7de3d81befe119c913df273488
Reviewed-on: https://chromium-review.googlesource.com/452858
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/5184c0cc86471f41ae8920af77a922483cb9c964/server/hosts/cros_repair.py

Status: Verified (was: Assigned)
Our pool:crouton devices are running tests now. Thanks!

Sign in to add a comment