Issue metadata
Sign in to add a comment
|
Harmony: all the "other" Content Settings Bubbles (Location, Media, ..) |
||||||||||||||||||||||||||
Issue descriptionChrome Version : 58.0.3026.3 There's a dialog browser test for all/most of these added by kylixrd - https://codereview.chromium.org/2668833003 It can also be shown on https://permission.site by requesting things, then denying them. You get an icon next to the bookmark star on the right of the omnibox. One is Protocol Handler: Issue 652024 One is Blocked Plugins: Issue 652030 One is Blocked Popups: Issue 652031 All others I suggest accumulating on this bug. Examples attached (mac). Note some of the dialogs currently use a bold font for the "domain", which doesn't have an equivalent in the Harmony typography spec ( Issue 691891 )
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
,
Aug 15 2017
There's a few parts of this UI that are in question, prior to us evaluating the pixels so this review is a bit different from the rest: ---------------- Title strings I'd like to get approval for changing these strings. It'll make this layouts a lot more manageable and predictable. Proposal is here: https://docs.google.com/document/d/1SeWNrpCqqHBhS3M6CixChfbobadz-h4vWG20I0PCaZI/edit?ts=59936180 ---------------- Specs - Regardless of the strings, the HTML redlines still apply for 90% of the expected design, so you should reference these to start https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec/_html#%3Fz=width&f=hidden ---------------- Mocks https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/11-Permissions#%3Fz=width Note that the "Manage" button now has a permanent home to the LHS of the dialog, for LTR languages. This is not reflected in the specs, but is the expected design.
,
Aug 21 2017
,
Aug 23 2017
I'm going to load-balance this to Elly's plate.
,
Aug 24 2017
,
Aug 25 2017
Issue 736318 has been merged into this issue.
,
Aug 25 2017
Elly, bug 736318 notes that the .xibs for Mac versions of these bubbles are the only places now that various "manage" strings are used, so we should remember to remove those strings when switching Mac to views. I don't know if that's best captured on this bug or somewhere else, I figured you'd have a better idea.
,
Aug 28 2017
I'll try to get this done by end of next week.
,
Sep 5 2017
,
Sep 14 2017
Changes that need to be made to have this match the mocks: 1) The bubble needs a short title, like "Location allowed" - these will need new strings 2) The longer descriptive text needs to be faded to grey 3) The origin should no longer appear in the bubble 4) The "clear these settings for future visits" link becomes a checkbox labeled "Clear permissions on next reload of page" A CL will be up shortly.
,
Sep 14 2017
Question about the geolocation bubble: it currently supports a very fine-grained view of which origins are using this permission - see the attached screenshot. The Harmony mocks don't have an example of this at all. a) Should we support this level of detail? We could yank it all out and just say "This tab is allowed / blocked", or we could leave it in b) If we decide to leave it in what should it look like?
,
Sep 20 2017
,
Sep 25 2017
I have a CL up at <https://chromium-review.googlesource.com/c/chromium/src/+/681852> to redo the detail view used for listing hosts - see the attached screenshots. This hasn't had UX review but I think it looks better. Once that is done, I think this bubble is mostly okay.
,
Sep 27 2017
Other dialogs affected by bullet refactoring.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0660c489e204cdb818676b2f7d45e4f3f0490b0 commit e0660c489e204cdb818676b2f7d45e4f3f0490b0 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Sep 28 18:34:02 2017 views: prettify domain list in geolocation permission bubble This change: 1) Adds a new class, ContentSettingDomainListView, which draws a titled list of domains; 2) Makes ContentSettingBubbleContents use that new class; 3) Adds a new class, BulletView, which draws a marker bullet for an unordered list; 4) Makes SadTabView and ExtensionInstallDialogView use BulletView. Bug: 700196 Change-Id: I2e1999b452277023ca071c0f8a7457fa405e3f00 Reviewed-on: https://chromium-review.googlesource.com/681852 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#505094} [modify] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/content_setting_bubble_contents.cc [add] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/content_setting_domain_list_view.cc [add] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/content_setting_domain_list_view.h [modify] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [add] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/harmony/bulleted_label_list_view.cc [add] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/harmony/bulleted_label_list_view.h [modify] https://crrev.com/e0660c489e204cdb818676b2f7d45e4f3f0490b0/chrome/browser/ui/views/sad_tab_view.cc
,
Sep 28 2017
Here are a couple of the permission-in-use bubbles for camera and microphone, as of <https://chromium-review.googlesource.com/c/chromium/src/+/690801>.
,
Sep 29 2017
The NextAction date has arrived: 2017-09-29
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec4f94005f693b2799a166008dc95a8e08044aa9 commit ec4f94005f693b2799a166008dc95a8e08044aa9 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Oct 03 10:49:26 2017 views: harmonize camera/microphone in use bubble This change: 1) Shortens the existing titles to Harmony-style short titles 2) Adds a message to these bubbles containing the existing long text 3) Removes the extra padding between title and body in Harmony mode Bug: 700196 Change-Id: I29489ec3a78b2ab1c229cfe84c516e251cea6d38 Reviewed-on: https://chromium-review.googlesource.com/690801 Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506002} [modify] https://crrev.com/ec4f94005f693b2799a166008dc95a8e08044aa9/chrome/app/generated_resources.grd [modify] https://crrev.com/ec4f94005f693b2799a166008dc95a8e08044aa9/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/ec4f94005f693b2799a166008dc95a8e08044aa9/chrome/browser/ui/content_settings/content_setting_bubble_model.h [modify] https://crrev.com/ec4f94005f693b2799a166008dc95a8e08044aa9/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc [modify] https://crrev.com/ec4f94005f693b2799a166008dc95a8e08044aa9/chrome/browser/ui/views/content_setting_bubble_contents.cc
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f808e464d4c7d0f3b2856e62e7882eb6ceae0c97 commit f808e464d4c7d0f3b2856e62e7882eb6ceae0c97 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Oct 19 14:53:39 2017 views: update content setting bubble strings This change: 1) Migrates the existing long title strings to corresponding message strings 2) Adds new short title strings 3) Adds titlecase variants for titles that did not previously have them Bug: 700196 Change-Id: I2f1373fabeeb4e9ad946374c2f00a3fe46904ccf Reviewed-on: https://chromium-review.googlesource.com/723939 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#510085} [modify] https://crrev.com/f808e464d4c7d0f3b2856e62e7882eb6ceae0c97/chrome/app/generated_resources.grd [modify] https://crrev.com/f808e464d4c7d0f3b2856e62e7882eb6ceae0c97/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/f808e464d4c7d0f3b2856e62e7882eb6ceae0c97/chrome/browser/ui/content_settings/content_setting_bubble_model.h [modify] https://crrev.com/f808e464d4c7d0f3b2856e62e7882eb6ceae0c97/chrome/browser/ui/content_settings/content_setting_image_model.cc
,
Oct 31 2017
We should try and keep the page action dialogs sized at 320 if possible
,
Nov 10 2017
,
Nov 15 2017
Issue 781131 has been merged into this issue.
,
Feb 18 2018
,
Oct 17
Mac triage: this is Fixed. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Mar 15 201723.1 KB
23.1 KB View Download
26.2 KB
26.2 KB View Download