New issue
Advanced search Search tips

Issue 700189 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
rdevlin....@chromium.org
bettes@chromium.org
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Replace App Info Dialog with MD-Extensions UI

Project Member Reported by tapted@chromium.org, Mar 9 2017 
Chrome Version       : 58.0.3026.3

Mac: First flip chrome://flags/#app-info-dialog

You can show this dialog by going to chrome://extensions and clicking 'Details' or by going to chrome://apps, right-clicking and selecting "App Info"

On ChromeOS, it can also be shown from the app launcher.

Attaching how it looks on Mac with chrome://flags/#secondary-ui-md

Hosted/"Bookmark" apps show a combobox. Permissions are shown, and the list may scroll.

It never launched on Mac ( Issue 485854 )
It launched on other platforms in  Issue 266739 , which has more screenshots.
For some crazy mocks that were never implemented, see  Issue 297403
Screen Shot 2017-03-10 at 9.48.27 am.png
137 KB View Download
Screen Shot 2017-03-10 at 9.48.45 am.png
117 KB View Download
Screen Shot 2017-03-10 at 9.49.26 am.png
152 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8beb72634fdd04bb6b4ad35e87888ceae17b9693

commit 8beb72634fdd04bb6b4ad35e87888ceae17b9693
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jul 12 18:45:44 2017

Add BrowserDialogTests for AppInfoDialog and InvertBubbleView.

Bug: 700189, 739961
Change-Id: I07b708d3a21e8a9af485ed1320af8564d4271abe
Reviewed-on: https://chromium-review.googlesource.com/562897
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486036}
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.h
[add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/hung_renderer_view_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/test/BUILD.gn

Comment 2 by pkasting@chromium.org, Aug 9 2017

Labels: -M-59

Comment 3 by pkasting@chromium.org, Aug 9 2017

Summary: Harmony App Info Dialog [needs mock] (was: Harmony App Info Dialog (needs mocks))

Comment 4 by bettes@chromium.org, Aug 21 2017

Cc: rdcronin@chromium.org
Owner: ----
Status: Available (was: Assigned)
This UI is on track to be removed with MD-Extensions WebUI. See #enable-md-extensions. We should de-prioritize this as much as possible.

Comment 5 by pkasting@chromium.org, Aug 23 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 24

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by tapted@chromium.org, Aug 27

Cc: -rdcronin@chromium.org rdevlin....@chromium.org benwells@chromium.org bettes@chromium.org
Components: Platform>Apps
Labels: -OS-Mac -Proj-HarmonyDialogs Proj-MaterialDesign-WebUI
Status: Available (was: Untriaged)
Summary: Replace App Info Dialog with MD-Extensions UI (was: Harmony App Info Dialog [needs mock])
So should 'App Info' from chrome://apps just navigate to chrome://extensions/?id=lkjlajklkdhaneeelolkfgbpikkgnkpk ?

I'm pretty sure MD-extensions is fully launched now, so the other entrypoint, from the old chrome://extensions, is now gone.


That would let us make this dialog ChromeOS-only.

Then, what about 'App Info' from the AppList UI on ChromeOS ? (e.g. Should that open a browser tab?)

Comment 8 by benwells@chromium.org, Aug 27 

Not all apps are shown on chrome://extensions - it doesn't show hosted or bookmark apps. So that alone isn't enough.
►

Sign in to add a comment