New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700169 link

Starred by 4 users
Status: Fixed
Owner:
shinyak@chromium.org
Closed: Mar 2018
Cc:
█ dschuyler@chromium.org
ukai@chromium.org
tikuta@chromium.org
yyanagisawa@chromium.org
shinyak@chromium.org
sque@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

goma fails with no error message besides the FAILED command

Project Member Reported by michae...@chromium.org, Mar 9 2017 
goma has caused some grief lately to me and another engineer. a huge number of `gomacc <...> <file>.o` commands fail on a clean ToT checkout, with no error/diagnostics.

Restarting goma solved the problem, but it took us a while to realize goma *was* the problem. gomacc should output something more useful when this happens.

For a typical build (non-debug, component, use_goma), the errors looked like:

[582/17457] CXX obj/third_party/woff2/woff2_dec/variable_length.o
FAILED: obj/third_party/woff2/woff2_dec/variable_length.o 
/usr/local/google/home/michaelpg/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/woff2/woff2_dec/variable_length.o.d -DV8_DEPREC
ATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DDISABLE_NACL -DFULL_SAFE_BROWS
ING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"296320-1\" -D_FILE_OFFSET_BITS=64
 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/woff2/src -I../.. -Igen -I../../third_pa
rty/brotli/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPI
C -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=..
/../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-pl
ugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hyg
iene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-cov
ered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-
nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exception
s -Wno-deprecated -c ../../third_party/woff2/src/variable_length.cc -o obj/third_party/woff2/woff2_dec/variable_length.o
[583/17457] CXX obj/third_party/woff2/woff2_dec/woff2_dec.o
FAILED: obj/third_party/woff2/woff2_dec/woff2_dec.o 
/usr/local/google/home/michaelpg/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/woff2/woff2_dec/woff2_dec.o.d -DV8_DEPRECATION_
WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DDISABLE_NACL -DFULL_SAFE_BROWSING -D
SAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"296320-1\" -D_FILE_OFFSET_BITS=64 -D_LA
RGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/woff2/src -I../.. -Igen -I../../third_party/brotli/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pip
e -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../bu
ild/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -
Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -
Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-s
witch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonpor
table-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno
-deprecated -c ../../third_party/woff2/src/woff2_dec.cc -o obj/third_party/woff2/woff2_dec/woff2_dec.o
[619/16914] CXX obj/v8/v8_libsampler/sampler.o
FAILED: obj/v8/v8_libsampler/sampler.o

Comment 1 by dschuyler@chromium.org, Mar 9 2017 

I hit this as well.

It would be great if the build stopped entirely and goma said something like:

"GOMA is out of date, please restart GOMA"

Comment 2 by tommycli@chromium.org, Mar 9 2017 

This happened to me I'm on GOMA version 124. I don't think it updated GOMA, I just needed to restart it. I think maybe the daemon died for some reason.

using /tmp/goma_tommycli as tmpdir
Using goma VERSION=124 (latest)
GOMA version 875b1d86587a6449c2dee88d0f8da8ba90305070@1488954892
14250
compiler proxy (pid=14250) status: http://127.0.0.1:8088 ok

Now goma is ready!

Comment 3 by shinyak@chromium.org, Mar 10 2017 

Hmm, sorry for the incovenience. It might come from the version difference between compiler_proxy <-> gomacc...

Comment 4 by tfarina@chromium.org, May 12 2017

Owner: shinyak@chromium.org
Status: Assigned (was: Untriaged)
Have you filed this internally as well?

Comment 5 by shinyak@chromium.org, May 15 2017 

This will happen when gomacc <-> compiler_proxy protocol changes.
When this happened, yeah, we had protocol change.

upstream: b/36105832
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/758a40cb86d538bdeebd57563056fcde9eb6965b

commit 758a40cb86d538bdeebd57563056fcde9eb6965b
Author: Shinya Kawanaka <shinyak@google.com>
Date: Thu Jun 22 10:03:00 2017
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/7674d3b4b3de77ff302e75a7ae81dfb2e871d73c

commit 7674d3b4b3de77ff302e75a7ae81dfb2e871d73c
Author: Shinya Kawanaka <shinyak@google.com>
Date: Fri Jun 23 02:22:05 2017

Comment 8 by shinyak@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
Now that 
  1. gomacc <-> compiler_proxy version is checked
  2. cache is invalidated when goma version is up.

I believe this has been fixed.
►

Sign in to add a comment