DCHECK when connecting to a host with an existing chromoting session. |
|||
Issue descriptionChrome Version: 57.0.2987.98 (64-bit) Host Version: 56.0.2924.51 Webapp Version: 57.0.2987.0 (v2) OS Linux What steps will reproduce the problem? (1) Connect to a host from the CRD Chrome App (Client 1) (2) Initiate a connection from another CRD Chrome App (Client 2) What is the expected result? Client2 is connected and Client 1 is disconnected gracefully What happens instead? When Client2 is connected, The Chromoting plugin crashed due to an DCHECK [0309/220205.057950:FATAL:message_reader.cc(88)] Check failed: result < 0 (0 vs. 0)
,
Mar 17 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b4667bc57d3ce2230e556ba38dcdc9342bdf819 commit 5b4667bc57d3ce2230e556ba38dcdc9342bdf819 Author: sergeyu <sergeyu@chromium.org> Date: Fri Mar 17 19:12:48 2017 Update ICE protocol to handle closed channel An ICE/PseudoTcp channel may be closed by the peer. Read() may returns 0 in that case. MessageReader wasn't expecting 0 and was DCHECK'ing in that case. Also update StreamMessagePipeAdapter to handle this case as closed MessagePipe. BUG= 700167 Review-Url: https://codereview.chromium.org/2757723002 Cr-Commit-Position: refs/heads/master@{#457842} [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/connection_tester.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/connection_tester.h [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/fake_session.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/fake_stream_socket.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/fake_stream_socket.h [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/ice_connection_to_client.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/ice_connection_to_host.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/message_reader.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/message_reader_unittest.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/stream_message_pipe_adapter.cc [modify] https://crrev.com/5b4667bc57d3ce2230e556ba38dcdc9342bdf819/remoting/protocol/stream_message_pipe_adapter.h
,
Mar 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sergeyu@chromium.org
, Mar 14 2017Status: Assigned (was: Untriaged)