MD Settings: Address Certificate manager feedback |
||||||
Issue descriptionCopied from https://bugs.chromium.org/p/chromium/issues/detail?id=478982&desc=2#c46. Manage Certificates on Linux looks good to me, just some nits: - The focus state on the hamburger menu on "Your Certificates" feels weird to me. If I click the hamburger menu, then click away, there remains a gray circle around it. Intentional? - The "Trust settings" header on the "Certificate authority" dialog (see screenshot) looks a little squished/awkwardly placed to me. Also on stable it's "Edit trust settings" rather than "Trust settings", not sure if that's intentional. - "Others tab: the wording "You have no certificates" is a little confusing, since you do have certificates, they just are categorized in the other tabs. "You have no other certificates" ?
,
Mar 17 2017
,
Mar 20 2017
+bettes: Please approve or disapprove changes at bullet points 2,3,4 below. @estark: 1) Regarding hamburger menu: Yes, intentional, see more details at https://codereview.chromium.org/2464873003. 2) Regarding "trust settings" header being squished, does it look better if the margin is increased (see attachment)? 3) Regarding "Trust settings" VS "Edit trust settings", it was originally specified as the latter and changed to the former based on UX request (see mocks at [1]. I am fine with changing it back to "Edit trust settings", if UX is OK with it. 4) "You have no other certificates" OR "You have no certificates in this category" SGTM. Again, the current strings are specified in the mocks at [1], so need to check with UX. [1] https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Privacy_03.png%3Fz=width
,
Mar 20 2017
,
Mar 23 2017
Re comment 3: #2: yes that looks much better to me, thanks! #3: I don't have any preference between the two, just wanted to make sure it was an intentional rather than accidental change.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc16b8ab7df17b1462d98640d6dd8cb1ccd2dbce commit cc16b8ab7df17b1462d98640d6dd8cb1ccd2dbce Author: dpapad <dpapad@chromium.org> Date: Fri Mar 31 22:05:58 2017 MD Settings: Tweak margin of "Trust settings" header. BUG= 700126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2790993002 Cr-Commit-Position: refs/heads/master@{#461244} [modify] https://crrev.com/cc16b8ab7df17b1462d98640d6dd8cb1ccd2dbce/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22fecb03c22982be2034c89bbb1cf1833bd4e330 commit 22fecb03c22982be2034c89bbb1cf1833bd4e330 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 04 23:39:41 2017 MD Settings: Tweak "no certificates" string based on feedback. BUG= 700126 Review-Url: https://codereview.chromium.org/2795383002 Cr-Commit-Position: refs/heads/master@{#461899} [modify] https://crrev.com/22fecb03c22982be2034c89bbb1cf1833bd4e330/chrome/app/settings_strings.grdp
,
Apr 4 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbeam@chromium.org
, Mar 13 2017Labels: Hotlist-MD-Settings-Privacy-CertificateManager
Status: Available (was: Untriaged)