New issue
Advanced search Search tips

Issue 700108 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 702851
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit check for adding new DEPS warns on reordering

Project Member Reported by dcheng@chromium.org, Mar 9 2017

Issue description

$ git diff HEAD^
diff --git a/chrome/DEPS b/chrome/DEPS
index ee445364bf02..5fd4d194ec27 100644
--- a/chrome/DEPS
+++ b/chrome/DEPS
@@ -25,8 +25,8 @@ include_rules = [
   "+content/public/common",
   "+content/public/test",
   "+media/media_features.h",
-  "+mojo/common",
   "+mojo/public",
+  "+mojo/common",
   "+ppapi/features",

   # Don't allow inclusion of these other libs we shouldn't be calling directly.

$ git cl presubmit -u
Running presubmit upload checks ...

** Presubmit Messages **
Missing OWNER reviewers for these files:
    chrome/DEPS

Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    sky@chromium.org

You need LGTM from owners of depends-on paths in DEPS that were modified in this CL:
    '+mojo/common',

Suggested missing target path OWNERS:
    rockot@chromium.org

Presubmit checks took 1.4s to calculate.

Presubmit checks passed.

We shouldn't warn in this case, as we're just moving a dep around to fix ordering issues.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d67e7158df1e98a04882fd10696adb65a0c3f511

commit d67e7158df1e98a04882fd10696adb65a0c3f511
Author: Daniel Cheng <dcheng@chromium.org>
Date: Thu Apr 13 08:38:03 2017

Fix GetOldContents() to return an empty string if the file didn't exist.

Bug:  700108 
Change-Id: I9010aa3b4aa467c91b93ffac924b3ec5a16cfaa2
Reviewed-on: https://chromium-review.googlesource.com/476590
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>

[modify] https://crrev.com/d67e7158df1e98a04882fd10696adb65a0c3f511/scm.py

Mergedinto: 702851
Status: Duplicate (was: Available)

Sign in to add a comment