Poor file icon fetching performance on Windows
Reported by
biohazar...@gmail.com,
Mar 9 2017
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Download some .exe 2. Close browser 3. Launch browser 4. Open downloads page What is the expected behavior? File icons for files appear consistently fast What went wrong? Icon fetching performance is inconsistent and might take up to 2s or even more on a performant desktop PC. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: 10.0 Flash Version: It is not directly affecting chromium, or at least not in really significant way, (just on the downloads page), but the code responsible for icon fetching is pretty slow on windows. I don't think it is chromium fault, but Windows API used being slow. The way I got into this issue is via porting(mostly copy-paste) some of the icon fetching code into electron framework. On Linux, it works perfectly fine, but when running on Windows (on a performant desktop PC), getting 1-2s delay per icon is not uncommon. Electron PRs: https://github.com/electron/electron/pull/7851 https://github.com/electron/electron/pull/8704 I'll try to attach some tracing info, but it seems like the issue is in SHGetFileInfo function being slow, and that's a known fact.
,
Mar 9 2017
Even msdn says it may be slow. https://msdn.microsoft.com/en-us/bb761854
,
Mar 9 2017
,
Mar 9 2017
Files downloaded from untrusted network zone have a special ADS (alternative NTFS data stream). Windows OS checks such files first by issuing a network request to verify the embedded file certificate in case it's an executable. It also checks file's hashsum. Both these operations take time, there's nothing Chrome can do AFAIK. You can try disabling this Windows feature at your own risk.
,
Mar 9 2017
,
Mar 10 2017
Attempting to upload trace on behalf of reporter.
,
Mar 15 2017
biohazard707@ could you please respond to comment #4
,
Mar 15 2017
Where can I find a setting for it?
,
Mar 15 2017
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2017
#9 >Where can I find a setting for it? A few links I've just googled up: 1. http://www.tweaklibrary.com/Software_Applications/Internet-Explorer/27/Disable-signature-verification-of-downloaded-programs/11387/ 2. http://www.thewindowsclub.com/zoneidtrimmer-remove-zone-identifier
,
Mar 20 2017
@biohazard707-- Could you please check as per comment #11 and update the thread. Thanks!
,
Mar 20 2017
Yes, as soon as I get to a Windows PC. Sorry for delay.
,
Mar 20 2017
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2017
#11 yes, disabling it speeds it up. Though I wonder if it is possible to make it fast by default without security tweaks.
,
Mar 23 2017
Marking as WontFix for now. Looks like it's expected behavior for the windows APIs. Maybe caching icons could fix this?
,
Mar 23 2017
,
Mar 24 2017
#16 are IExtractIcon APIs subject to this problem too? |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by danakj@chromium.org
, Mar 9 2017