New issue
Advanced search Search tips

Issue 700098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

CancelMethod/NavigationSimulatorTest.Cancel browser_side_navigation_content_unittests failing on chromium.linux/Linux Tests (dbg)(1)

Project Member Reported by fs...@chromium.org, Mar 9 2017

Issue description

browser_side_navigation_content_unittests failing on chromium.linux/Linux Tests (dbg)(1)

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29

It's getting:

[ RUN      ] CancelMethod/NavigationSimulatorTest.Cancel/4
[21922:21922:0309/094658.326601:7255400592:FATAL:navigation_handle_impl.cc(591)] Check failed: !render_frame_host_ || render_frame_host_ == render_frame_host. 

I can't figure out if it's 2737553003 or 2668603003.
 

Comment 1 by fs...@chromium.org, Mar 9 2017

Cc: csharrison@chromium.org
It could also (probably?) be 2698393002 ? csharrison?
Given that everything else works, and my CL was just an API refactor (Though a big and complex enough one that it could conceivably have broken stuff), my money's on 2698393002.
Owner: csharrison@chromium.org
Status: Started (was: Available)
Already working on it.

CL:
https://codereview.chromium.org/2744593004/
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a7108a65a43fafa4fa35fc208efb40503142f5

commit f9a7108a65a43fafa4fa35fc208efb40503142f5
Author: csharrison <csharrison@chromium.org>
Date: Thu Mar 09 21:15:48 2017

Fix use-after-free in NavigationSimulator test util

This was causing ASAN/TSAN errors under PlzNavigate

BUG= 700098 

Review-Url: https://codereview.chromium.org/2744593004
Cr-Commit-Position: refs/heads/master@{#455864}

[modify] https://crrev.com/f9a7108a65a43fafa4fa35fc208efb40503142f5/content/public/test/navigation_simulator.cc

Status: Fixed (was: Started)

Sign in to add a comment