New issue
Advanced search Search tips

Issue 700092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 702849

Blocking:
issue 707006
issue 711447
issue 701176



Sign in to add a comment

[WPT Export] Make a PR when an exportable CL is uploaded to Gerrit

Project Member Reported by jeffcarp@chromium.org, Mar 9 2017

Issue description

As an intermediate solution we made the exporter asynchronous ( bug 702849 ), which no longer means we can be blocked by one stuck PR, but comes with the tradeoff that commits may be merged out of order.

The more preferable solution is to keep changes that won't pass WPT Travis CI from ever landing on Chromium master. There are two initiatives to solve this:
1. Run the lint and stability scripts in the CQ,  issue 686927 
2. Create WPT PR for in-flight Gerrit CLs (this issue)

Blocking in-flight CLs from landing until their corresponding Travis CI is green is the only way we can be 100% sure all changes that make it to Chromium master can be exported.

This work is targeting Gerrit since Chromium is in the process of moving to it from Rietveld right now.
 
Labels: -Type-Bug Type-Feature
Blocking: 701147
Blocking: 701176
Blocking: -686471 -701147
Removing blocking bugs due to simplification of plans. To solve the head of line blocking  bug 686471 , first we're going to make the export process asynchronous before supporting pre-emptive CLs on Gerrit.
Blockedon: 702849
Blocking: 707006
Cc: smcgruer@chromium.org
Description: Show this description
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9

commit c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Thu Apr 13 19:48:08 2017

Query exportable Gerrit in-flight CLs and print them out

This is in preparation for creating PRs for Gerrit CLs.

Bug:  700092 
Change-Id: I6300565986a90e4e9e9e6c834ed91b52864af0fb
Reviewed-on: https://chromium-review.googlesource.com/475205
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464513}
[modify] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
[modify] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
[add] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
[add] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit_mock.py
[modify] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/c472f8a3eb4e5fbc74c7007b4c4446f8cd80bcb9/third_party/WebKit/Tools/Scripts/wpt-export

Blocking: 711447
Project Member

Comment 11 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff67881b79d0206fbc26d3f98789547935785cb5

commit ff67881b79d0206fbc26d3f98789547935785cb5
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Thu May 11 20:40:33 2017

[WPT Export] Create GitHub PRs from Gerrit CLs

Bug:  700092 
Change-Id: I7fd398d1e25b77493eef609cbf818747216cd140
Reviewed-on: https://chromium-review.googlesource.com/479931
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471061}
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit_mock.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
[modify] https://crrev.com/ff67881b79d0206fbc26d3f98789547935785cb5/third_party/WebKit/Tools/Scripts/wpt-export

Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b5b69a06ceb363fa42500b5b546deb22d08ffdd

commit 9b5b69a06ceb363fa42500b5b546deb22d08ffdd
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Thu May 11 23:07:15 2017

Revert "[WPT Export] Create GitHub PRs from Gerrit CLs"

This reverts commit ff67881b79d0206fbc26d3f98789547935785cb5.

Reason for revert: Updated credentials but that uncovered a bug with how we handle responses from the Gerrit API.

Original change's description:
> [WPT Export] Create GitHub PRs from Gerrit CLs
> 
> Bug:  700092 
> Change-Id: I7fd398d1e25b77493eef609cbf818747216cd140
> Reviewed-on: https://chromium-review.googlesource.com/479931
> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#471061}

TBR=qyearsley@chromium.org,jeffcarp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug:  700092 

Change-Id: Ieb6f34d9762184033c10d6ba7c3b4e8208a7fe5b
Reviewed-on: https://chromium-review.googlesource.com/503553
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471109}
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit_mock.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
[modify] https://crrev.com/9b5b69a06ceb363fa42500b5b546deb22d08ffdd/third_party/WebKit/Tools/Scripts/wpt-export

Project Member

Comment 13 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f2451fdb2d51d41106da071716e9d8349e66b4

commit 01f2451fdb2d51d41106da071716e9d8349e66b4
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Fri May 12 17:46:17 2017

[WPT Export] Reland of Create GitHub PRs from Gerrit CLs

Bug:  700092 
Change-Id: Ide415b53d19148f2f01ab5e9df0844091c8bedae
Reviewed-on: https://chromium-review.googlesource.com/503539
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471355}
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit_mock.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
[modify] https://crrev.com/01f2451fdb2d51d41106da071716e9d8349e66b4/third_party/WebKit/Tools/Scripts/wpt-export

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ae907168095c6dd81ab59d5b69619c30450170

commit 35ae907168095c6dd81ab59d5b69619c30450170
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Sat May 13 00:02:31 2017

Remove extra newline at end of WPT file for WPT Exporter testing

Bug:  700092 
Change-Id: I60d34bfc70741f03bff10453ce0934631f0df0cd
Reviewed-on: https://chromium-review.googlesource.com/479676
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471499}
[modify] https://crrev.com/35ae907168095c6dd81ab59d5b69619c30450170/third_party/WebKit/LayoutTests/external/wpt/workers/semantics/multiple-workers/001.html
[modify] https://crrev.com/35ae907168095c6dd81ab59d5b69619c30450170/third_party/WebKit/LayoutTests/external/wpt/workers/semantics/xhr/004.html

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e0c2d07ec0079f4ecde7f6fc2c1643e1d1d4412b

commit e0c2d07ec0079f4ecde7f6fc2c1643e1d1d4412b
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Jun 26 20:01:39 2017

Use --credentials-json in wpt_export recipe.

After some recent changes in the wpt-export script, we are now reading
Gerrit credentials from a file and not just GitHub credentials, so the
argument is being renamed to credentials-json.

I just noticed this in wpt-export and saw that it was a quick change.

Bug:  700092 
Change-Id: Iea13d18065a5ba15774127017c0608c655a2f29f
Reviewed-on: https://chromium-review.googlesource.com/548837
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/e0c2d07ec0079f4ecde7f6fc2c1643e1d1d4412b/recipes/recipes/wpt_export.py
[modify] https://crrev.com/e0c2d07ec0079f4ecde7f6fc2c1643e1d1d4412b/recipes/recipes/wpt_export.expected/wpt-export.json

Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment