New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700084 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 697665
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

17.9%-18.1% regression in loading.mobile at 453912:453933

Project Member Reported by benhenry@google.com, Mar 9 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=700084

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1MHAswsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1OTG7wkM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : loading.mobile
  Metric       : timeToFirstContentfulPaint_avg/Regular-3G/https___www.youtube.com_watch?v_MU3YuvNRhVY

Revision             Result                  N
chromium@453911      10803.9 +- 2768.15      21      good
chromium@453933      10702.6 +- 2045.77      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...www.youtube.com.watch.v.MU3YuvNRhVY loading.mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8985574488709054160

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5521266133434368


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Labels: Performance-Loading
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 21 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : loading.mobile
  Metric       : timeToFirstContentfulPaint_avg/Regular-3G/http___www.francetvinfo.fr

Revision             Result                  N
chromium@453361      3279.76 +- 670.799      21      good
chromium@453928      3384.67 +- 658.22       21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.francetvinfo.fr loading.mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976203092818451536

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6183532629590016


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 21 2017

Cc: rogerm@chromium.org
Owner: rogerm@chromium.org

=== Auto-CCing suspected CL author rogerm@chromium.org ===

Hi rogerm@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : rogerm
  Commit : 2233a4a7cb12ac4acdebd33491b528f8fb670f02
  Date   : Mon Feb 27 23:11:16 2017
  Subject: [translate] Add translate ranker model loader.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : loading.mobile
  Metric       : timeToFirstContentfulPaint_avg/Regular-3G/http___www.francetvinfo.fr
  Change       : 2.72% | 5627.60422222 -> 5762.347

Revision             Result                  N
chromium@453361      5627.6 +- 259.925       9       good
chromium@453370      5619.73 +- 142.116      9       good
chromium@453375      5782.74 +- 2075.4       14      good
chromium@453377      5766.23 +- 1781.97      14      good
chromium@453378      5784.98 +- 134.2        6       bad       <--
chromium@453379      5781.99 +- 205.135      9       bad
chromium@453397      5755.17 +- 173.365      9       bad
chromium@453432      5746.39 +- 78.4072      9       bad
chromium@453503      5764.96 +- 455.652      14      bad
chromium@453645      5753.27 +- 244.848      14      bad
chromium@453928      5762.35 +- 225.68       9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.francetvinfo.fr loading.mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976192742859437328

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6183532629590016


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
I believe this was expected, but the regression is quite large. Are there any ways to improve loading on mobile and keep this feature? Has this feature already gone through all of the necessary launch review steps? Can you please link the launch bug?
This CL has since been reverted, refactored, and relanded based on other larger regressions.

It's not clear what I should do with this.

See:  crbug.com/697665 ,  crbug.com/697947 
Cc: hamelphi@chromium.org yyushkina@chromium.org
Considering to close as duplicate of one of the aforementioned issues.
yeah, that sounds right! Or wontfix is fine.
Mergedinto: 697665
Status: Duplicate (was: Assigned)

Sign in to add a comment