All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=700081

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1Jaa7QkM


Bot(s) for this bug's original alert(s):

android-nexus6

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8985574619210448400

=== Auto-CCing suspected CL author xiaochengh@chromium.org ===

Hi xiaochengh@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : xiaochengh
  Commit : 2483390c3c56d62a8d65bb3bb3672102a4956505
  Date   : Wed Mar 08 02:11:12 2017
  Subject: Implement cold mode invocation for idle time spell checker

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : power.android_acceptance
  Metric       : fuel_gauge_energy_consumption_mwh/fuel_gauge_energy_consumption_mwh
  Change       : 63.19% | 11.7608082142 -> 19.1920440631

Revision             Result                   N
chromium@455239      11.7608 +- 0.777304      6      good
chromium@455338      11.3875 +- 0.46844       6      good
chromium@455342      10.3973 +- 1.96145       5      good
chromium@455343      10.9281 +- 0.539439      6      good
chromium@455344      17.8379 +- 3.40805       6      bad       <--
chromium@455345      19.032 +- 5.31239        6      bad
chromium@455351      18.4106 +- 4.9896        6      bad
chromium@455363      20.1535 +- 5.34854       6      bad
chromium@455388      17.2963 +- 0.589243      6      bad
chromium@455437      19.192 +- 4.44967        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests power.android_acceptance

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8985574619210448400

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5576311910694912


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Whoops... My fault.

The suspected CL mistakenly enabled the experimental feature IdleTimeSpellChecking that's supposed to be behind a flag.

I'll make it properly guarded by the flag.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/624c5cfae4ce865f8ac91be865a29ff0e9fdbe34

commit 624c5cfae4ce865f8ac91be865a29ff0e9fdbe34
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Mar 10 01:16:44 2017

Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG= 700081 , 517298 

Review-Url: https://codereview.chromium.org/2744603004
Cr-Commit-Position: refs/heads/master@{#455942}

[modify] https://crrev.com/624c5cfae4ce865f8ac91be865a29ff0e9fdbe34/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp
[modify] https://crrev.com/624c5cfae4ce865f8ac91be865a29ff0e9fdbe34/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp
[modify] https://crrev.com/624c5cfae4ce865f8ac91be865a29ff0e9fdbe34/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Thanks, xiaochengh@. The graph appears to have recovered since your change landed. 

This will also stop the crashing in issue 706329

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b

commit 29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Mar 30 21:16:45 2017

Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG= 700081 , 517298 ,706329

Review-Url: https://codereview.chromium.org/2744603004
Cr-Commit-Position: refs/heads/master@{#455942}
(cherry picked from commit 624c5cfae4ce865f8ac91be865a29ff0e9fdbe34)

Review-Url: https://codereview.chromium.org/2790763002 .
Cr-Commit-Position: refs/branch-heads/3029@{#499}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp
[modify] https://crrev.com/29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp
[modify] https://crrev.com/29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp