Decrease side padding on "Add supervised user" button |
||||
Issue descriptionWhat steps will reproduce the problem? (1) At login screen, click [...] button to display "Add supervised user" button (2) Observe excess whitespace on either side of text The button width is currently hardcoded to 180px: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/header_bar.css?q=button.add-supervised-user-menu This currently leaves 30px of padding on either side (in English). The button should behave like other shelf buttons (e.g., "App person"), with dynamic sizing, and 16px of spacing on either side. This is spun off from Issue 690824 . The screenshots showing ideal and current button spacing are copied from that bug. abodenha@- good first bug for noogler with some HTML/CSS knowledge?
,
Mar 9 2017
"stay the same" as in "Won't fix"?
,
Mar 9 2017
It would be best to fix it and to have consistent padding for all buttons. From what you mentioned, seems like it's hard to change on the engineering side?
,
Mar 11 2017
Is this bug in normal chrome browser seen in Windows desktop os, I am not able to replicate it. Just starting out with chromium so many parts may be new to me
,
Mar 14 2017
elizabethchiu@ - The change may not be hard at all, but my CSS is weak, so I'm not sure. Let's leave it open for now, and see if someone with better CSS skills can sort it out. zend.java@ - This bug references buttons on the shelf on Chrome OS. I'm not aware of these buttons existing in the browser.
,
Mar 15 2017
I believe that something like the below code is necessary,
.name_of_button{padding-left:16px;padding-right:16px;}
Maybe there are many other conditions that have to be looked at , so above code may not work easily
Will try getting to load chromeOs on windows, if I am able to do that then will take up this bug
,
Mar 15 2017
zend.java@ - Thanks for the advice. I'd played with padding before, but spent a little more time on it this morning. The problem was that it kept wrapping the text into three lines. Oddly enough, "nowrap" fixed the problem ;-) elizabethchiu@ - Ok, got the padding to 16px, sort of. One of those pixels is the one-pixel grey border around the button, so that it's actually 15px of whitespace. However, it's consistent with other buttons, insofar as there's 14px of space between the text and the blue focus box. See screenshots. Let me know if this seems right. Changes are in review at https://codereview.chromium.org/2751123002.
,
Mar 22 2017
elizabethchiu@ - I'm going to go ahead and land this if you've no objection.
,
Mar 22 2017
Thanks Greg! This is looking great but I would add 1 px to make it 16px, so that it's even.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e319aa3140da1136776ae4a2f2f843156ad0576b commit e319aa3140da1136776ae4a2f2f843156ad0576b Author: glevin <glevin@chromium.org> Date: Thu Mar 23 15:35:15 2017 Fix padding on Add Supervised User button BUG= 700064 TEST=On login screen, click [...] button, observe that horizontal padding on "Add supervised user" button is similar to other shelf buttons (16px). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751123002 Cr-Commit-Position: refs/heads/master@{#459091} [modify] https://crrev.com/e319aa3140da1136776ae4a2f2f843156ad0576b/chrome/browser/resources/chromeos/login/header_bar.css
,
Mar 23 2017
Thanks, Elizabeth, done!
,
May 8 2017
9532.0.0, 60.0.3092.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by elizabethchiu@chromium.org
, Mar 9 2017