Issue metadata
Sign in to add a comment
|
EXT_multisample_compatibility test failures on Android NVIDIA |
||||||||||||||||||||||||
Issue descriptionWe have these 2 Android NVIDIA bots on GPU.FYI waterfall now: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Pixel%20C%29 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28NVIDIA%20Shield%29 The both fail different EXT_multisample_compatibility related tests. NVIDIA Shield fails EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve in gl_tests. I 20.300s run_tests_on_device(042461600046800829f0) [ RUN ] EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve I 20.300s run_tests_on_device(042461600046800829f0) ../../gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:239: Failure I 20.301s run_tests_on_device(042461600046800829f0) Expected: (0) != (memcmp(results[0].get(), results[1].get(), kResultSize)), actual: 0 vs 0 I 20.301s run_tests_on_device(042461600046800829f0) [ FAILED ] EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve (105 ms) It also fails EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve/ES2_OPENGLES in angle_end2end_tests. I 29.633s run_tests_on_device(0424616022750008267f) [ RUN ] EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve/ES2_OPENGLES I 29.633s run_tests_on_device(0424616022750008267f) ../../third_party/angle/src/tests/gl_tests/MultisampleCompatibilityTest.cpp:294: Failure I 29.633s run_tests_on_device(0424616022750008267f) Expected: (0) != (memcmp(results[0].get(), results[1].get(), kResultSize)), actual: 0 vs 0 I 29.633s run_tests_on_device(0424616022750008267f) [ FAILED ] EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve/ES2_OPENGLES, where GetParam() = ES2_OPENGLES (86 ms) The test is skipped since https://chromium-review.googlesource.com/451877. Pixel C was reported to fail EXTMultisampleCompatibilityTest.TestSimple in gl_tests in issue 624621 . I 16.565s run_tests_on_device(5B24001812) [----------] 3 tests from EXTMultisampleCompatibilityTest I 16.565s run_tests_on_device(5B24001812) [ RUN ] EXTMultisampleCompatibilityTest.TestSimple I 16.565s run_tests_on_device(5B24001812) [ERROR:gpu_test_config.cc(261)] Fail to identify GPU gl_tests were disabled on it in https://codereview.chromium.org/2177723002/. It could be that Pixel C problem is different, as supposedly many gl_tests fail to identify GPU on it. I bring it here to warn that we don't have test coverage for EXT_multisample_compatibility on Android, except perhaps gl_tests on Nexus 9 bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29.
,
Mar 9 2017
The end2end test was suppressed in https://chromium-review.googlesource.com/c/451877/. 1. But not gl_tests one. 2. I think there should be an open bug to fix the actual failure.
,
Mar 10 2017
,
Mar 10 2017
Curiously I implemented the extension specifically targeting Pixel C, though I've never run it on the actual device. The extension itself is only used by Skia NV_path_rendering codepath. I've since obtained a Pixel C, so in theory I could spend some time debugging this. It's a bit pointless, though, since the perf blockers related to command buffer that we talked about a year ago have not been fixed.. Thus trying to move Skia Gpu raster, especially NVPR, forward seem a bit futile. Of course, as long as the code is three in the repo, it should work. As to reason for the test failure: Both of the tests, gl_tests and angle_end2end should be have similar logic: render some content. Toggle a flag. Render the same content. Chech that the contents differ, e.g. the flag had some effect. It may well be that I've somehow misunderstood how GL_SAMPLE_ALPHA_TO_ONE_EXT flag should work, and that toggling it should not have an effect on the content being rendered. GL_SAMPLE_ALPHA_TO_ONE itself is not used by Skia.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eb168bb343360ac7a0c13d4a45c410562173b1a commit 7eb168bb343360ac7a0c13d4a45c410562173b1a Author: ynovikov <ynovikov@chromium.org> Date: Fri Mar 10 22:44:20 2017 Skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield BUG= 700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2741853005 Cr-Commit-Position: refs/heads/master@{#456197} [modify] https://crrev.com/7eb168bb343360ac7a0c13d4a45c410562173b1a/gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47407132408753d4ef23a27545ec2a5fe84791e commit f47407132408753d4ef23a27545ec2a5fe84791e Author: ynovikov <ynovikov@chromium.org> Date: Wed Mar 15 01:40:27 2017 Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield. BUG= 700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2744663006 Cr-Commit-Position: refs/heads/master@{#456940} [modify] https://crrev.com/f47407132408753d4ef23a27545ec2a5fe84791e/gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc
,
Mar 15 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by geoffl...@chromium.org
, Mar 9 2017Status: Duplicate (was: Unconfirmed)