Touch Bar does not show the Home button |
||||||||||||
Issue descriptionChrome Version: 59.0.3036.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Turn on the Home button in Chrome Settings What is the expected result? The Home button should appear in the Touch Bar What happens instead? There is no Home button in the Touch Bar The Home button should appear/disappear as you toggle it in Settings (i.e. you shouldn't need to restart the browser or anything to start seeing it).
,
Mar 9 2017
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7 commit 0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7 Author: spqchan <spqchan@chromium.org> Date: Fri Mar 10 23:11:17 2017 [Mac] Add Home button to Default Touch Bar BUG= 700057 Review-Url: https://codereview.chromium.org/2743633005 Cr-Commit-Position: refs/heads/master@{#456209} [modify] https://crrev.com/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7/chrome/browser/ui/cocoa/browser_window_touch_bar.h [modify] https://crrev.com/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
,
Mar 10 2017
,
Mar 10 2017
I feel like it's not a good idea to request merge permission until after verifying on Canary. If you get approval today you have to remember not to act on it yet, and if there's a problem on Monday with the latest Canary and you land a fix, it seems like you will need to ask for Merge approval a second time.
,
Mar 10 2017
Sure thing
,
Mar 11 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2017
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fecbe09db0433c30982d44f707753090297c6ca9 commit fecbe09db0433c30982d44f707753090297c6ca9 Author: spqchan <spqchan@chromium.org> Date: Tue Mar 14 18:47:51 2017 [Mac] Add Home button to Default Touch Bar BUG= 700057 Review-Url: https://codereview.chromium.org/2743633005 Cr-Commit-Position: refs/heads/master@{#456209} (cherry picked from commit 0f0ed150a7c3aa62413e8d9cbe4d27594cc74af7) Review-Url: https://codereview.chromium.org/2741343008 . Cr-Commit-Position: refs/branch-heads/3029@{#191} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/fecbe09db0433c30982d44f707753090297c6ca9/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/fecbe09db0433c30982d44f707753090297c6ca9/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/fecbe09db0433c30982d44f707753090297c6ca9/chrome/browser/ui/cocoa/browser_window_touch_bar.h [modify] https://crrev.com/fecbe09db0433c30982d44f707753090297c6ca9/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/fecbe09db0433c30982d44f707753090297c6ca9/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
,
Mar 14 2017
,
Mar 17 2017
Tested the issue on Mac-10.12.3 using chrome version#59.0.3043.0 with the steps mentioned in comment#0. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!!
,
Mar 22 2017
Verified this issue on Mac 10.12.3 with chrome #58.0.3029.33 as per comment#0.Observed that the Home button appeared in the Touch Bar when user check the check box.Hence adding TE-Verified labels. Attaching the screen-cast for reference. Thanks!! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ligim...@chromium.org
, Mar 9 2017Labels: Needs-Bisect