https://luci-milo-dev.appspot.com/logdog/build/infra-experimental/swarm/chromium-swarm-dev.appspot.com/34ca0e65b247d611/+/annotations cannot be rendered because it tries to load the stream from luci-logdog.appspot.com and there is no query string parameter to specify the logdog host name. It uses the default logdog hostname which is hardcoded to be luci-logdog.appspot.com this complicates debugging of bug 700052 move the default to luci-config
Issue 695667 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/12104d6afc53cde67e7572a7b32ff062adaa2f0e commit 12104d6afc53cde67e7572a7b32ff062adaa2f0e Author: hinoka <hinoka@google.com> Date: Tue Mar 21 05:11:42 2017 Milo: Use luci-config for storing buildbot acls This moves buildbot acls to be checked from luci config rather than a magical project named "chrome" BUG= 700055 Review-Url: https://codereview.chromium.org/2760873003 [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/buildbot/pubsub_test.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/common/acl.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/common/acl_test.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/common/config.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/common/config_test.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/frontend/config.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/frontend/cron.yaml [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/appengine/frontend/main.go [modify] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/common/config/project.pb.go [add] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/common/config/settings.pb.go [add] https://crrev.com/12104d6afc53cde67e7572a7b32ff062adaa2f0e/milo/common/config/settings.proto
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/519f66769175156ffa5353450b81e815a696e218 commit 519f66769175156ffa5353450b81e815a696e218 Author: Ryan Tseng <hinoka@google.com> Date: Tue Mar 21 05:17:55 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/bdc67ecead9047e144fc5cf86452e8643a6ddf61 commit bdc67ecead9047e144fc5cf86452e8643a6ddf61 Author: Ryan Tseng <hinoka@google.com> Date: Tue Mar 21 05:26:27 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/99bf33b5a9b20232cb26f02ac57170a65575813f commit 99bf33b5a9b20232cb26f02ac57170a65575813f Author: Ryan Tseng <hinoka@google.com> Date: Tue Mar 21 08:30:00 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/7b8f0bda436990574664216e94d66e3fc5d4c372 commit 7b8f0bda436990574664216e94d66e3fc5d4c372 Author: Ryan Tseng <hinoka@google.com> Date: Tue Mar 21 18:06:57 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/be60414ac83c2d9586377814cb594dff08e1ec11 commit be60414ac83c2d9586377814cb594dff08e1ec11 Author: hinoka <hinoka@google.com> Date: Tue Mar 28 22:29:29 2017 Milo: Move instance configuration to luci-config This moves: * Buildbot Pubsub configs * Buildbucket host pointer * Swarming host pointer and whitelist To be configured in luci-config And some minor renaming for consistency. BUG= 700055 Review-Url: https://codereview.chromium.org/2765383002 [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbot/build.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbot/pubsub.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbucket/buckets.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbucket/builder.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbucket/builder_test.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/buildbucket/html.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/swarming/build.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/swarming/buildinfo.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/appengine/swarming/html.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/common/config/settings.pb.go [modify] https://crrev.com/be60414ac83c2d9586377814cb594dff08e1ec11/milo/common/config/settings.proto
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/54103200a0dd8f5d11714d8d7136b0bbe1c7f91e commit 54103200a0dd8f5d11714d8d7136b0bbe1c7f91e Author: Ryan Tseng <hinoka@google.com> Date: Thu Mar 30 17:43:07 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/70e653e0b63ec9f662fe757ca2302c86680ac74c commit 70e653e0b63ec9f662fe757ca2302c86680ac74c Author: Nodir Turakulov <nodir@google.com> Date: Thu Mar 30 20:37:20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/f20ac77a9e8927a7f766d0611b7e0935415cf4d1 commit f20ac77a9e8927a7f766d0611b7e0935415cf4d1 Author: Ryan Tseng <hinoka@google.com> Date: Mon Apr 03 18:27:26 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c commit a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c Author: hinoka <hinoka@google.com> Date: Thu Apr 06 03:54:12 2017 Milo: Use custom config caching layer Use our own caching layer for luci config. This allows for better failure conditions, and also the configs can be viewed. Some behavioral changes: * GetSettings() should never error, just returns an unfilled config. BUG= 700055 Review-Url: https://codereview.chromium.org/2801463002 [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/luci_config/server/cfgclient/backend/backend.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/luci_config/server/cfgclient/backend/client/client.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/luci_config/server/cfgclient/backend/erroring/erroring.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/luci_config/server/cfgclient/config_test.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/buildbot/pubsub.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/buildbot/pubsub_test.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/buildbucket/buckets.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/buildbucket/builder.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/buildbucket/builder_test.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/common/acl.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/common/config.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/common/config_test.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/config.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/cron.yaml [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/expectations/frontpage-Basic_frontpage.html [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/frontpage.go [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/templates/pages/configs.html [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/frontend/templates/pages/frontpage.html [modify] https://crrev.com/a42d0e810765a5abf65fe3c4d8a5fe1b4645e12c/milo/appengine/swarming/html.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/3480effab9aef665d5ab1574d68e3b2e95eed964 commit 3480effab9aef665d5ab1574d68e3b2e95eed964 Author: hinoka <hinoka@google.com> Date: Thu Apr 06 04:22:52 2017 Milo: Fix frontpage bug Leftover bug from https://codereview.chromium.org/2801463002/ BUG= 700055 TBR=nodir Review-Url: https://codereview.chromium.org/2799873002 [modify] https://crrev.com/3480effab9aef665d5ab1574d68e3b2e95eed964/milo/appengine/frontend/frontpage.go
This has been fixed and rolled.
Comment 1 by no...@chromium.org
, Mar 10 2017