New issue
Advanced search Search tips

Issue 700049 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GC issue in converting js-test to testharness

Project Member Reported by rtoy@chromium.org, Mar 9 2017 
In https://codereview.chromium.org/2717723002/, the test fails on windows because the GC counts aren't correct.  But the test passes on linux and mac.

However, if we don't convert to testharness, the test works just fine everywhere.  Is it an issue with testharness and Audit?

Comment 1 by hongchan@chromium.org, Mar 30 2017 

We should create 'legacy' directory in our layout tests and put everything depends on js-test into that folder.

Comment 2 by hongchan@chromium.org, Mar 30 2017 

By the way, this issue is about testharness not having 'internal' magic trick. Any test relies on those magic tricks will not be upstreamed to WPT.

Comment 4 by hongchan@chromium.org, Apr 10 2017

Status: Started (was: Assigned)
More comprehensive list with [gc\(\)|internals\.]:
https://cs.chromium.org/search/?q=gc%5C(%5C)%7Cinternals%5C.+file:%5Esrc/third_party/WebKit/LayoutTests/webaudio/+package:%5Echromium$&type=cs

It's about 10 files.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a844bfcadbed45ee48895081e72d7b9732f0100a

commit a844bfcadbed45ee48895081e72d7b9732f0100a
Author: hongchan <hongchan@chromium.org>
Date: Tue Apr 11 22:06:40 2017

Move layout tests that use 'js-test.js' to |internals| directory

Certain features in "resources/js-test.js" depends on special hooks
from Chromium test runner, and the test using these features cannot be
upstreamed. This directory is a collection of such test files.

BUG= 700049 

Review-Url: https://codereview.chromium.org/2815493002
Cr-Commit-Position: refs/heads/master@{#463793}

[add] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/README.md
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-close.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race-expected.txt
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/audiosource-premature-gc.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/audiosummingjunction-crash.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc-expected.txt
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc-expected.txt
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper-expected.txt
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper.html
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death-expected.txt
[rename] https://crrev.com/a844bfcadbed45ee48895081e72d7b9732f0100a/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death.html

Comment 6 by hongchan@chromium.org, Apr 11 2017

Status: Verified (was: Started)
►

Sign in to add a comment